Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LINQ ThenBy operator after OrderBy #801

Merged
merged 11 commits into from
Oct 8, 2019
Merged

Enable LINQ ThenBy operator after OrderBy #801

merged 11 commits into from
Oct 8, 2019

Conversation

khdang
Copy link
Member

@khdang khdang commented Sep 13, 2019 •
edited
Loading

Description

  • Enable LINQ ThenBy operator after OrderBy to use composite indexing
  • Refactor LINQ tests

E.g

LINQ with ThenBy

query.OrderBy(f => f.FamilyId).ThenBy(f => f.Int).ThenByDescending(f => f.IsRegistered)

SQL

SELECT VALUE root 
FROM root 
ORDER BY root["FamilyId"] ASC, root["Int"] ASC, root["IsRegistered"] DESC

Type of change

  • New feature (non-breaking change which adds functionality)

Closing issues

@khdang khdang added the LINQ label Sep 13, 2019
@khdang khdang self-assigned this Sep 13, 2019
@khdang khdang added this to In progress in .NET v3 Board via automation Sep 13, 2019
khdang
khdang commented Sep 13, 2019
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@khdang khdang changed the title Enable LINQ ThenBy operator after OrderBy and add type check functions Enable LINQ ThenBy operator after OrderBy Sep 18, 2019
.NET v3 Board automation moved this from In progress to Reviewer approved Sep 18, 2019
kirankumarkolli
kirankumarkolli reviewed Sep 18, 2019
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
.NET v3 Board automation moved this from Reviewer approved to Review in progress Sep 18, 2019
.NET v3 Board automation moved this from Review in progress to Reviewer approved Sep 18, 2019
@kirankumarkolli
Copy link
Member

@khdang can you please take a look at the test failures?

.NET v3 Board automation moved this from Reviewer approved to Review in progress Sep 27, 2019
@khdang
Copy link
Member Author

khdang commented Oct 3, 2019 •
edited
Loading

@khdang can you please take a look at the test failures?

I've updated the tests.

@khdang khdang closed this Oct 3, 2019
.NET v3 Board automation moved this from Review in progress to Done Oct 3, 2019
@khdang khdang reopened this Oct 3, 2019
.NET v3 Board automation moved this from Done to In progress Oct 3, 2019
.NET v3 Board automation moved this from In progress to Reviewer approved Oct 8, 2019
@kirankumarkolli kirankumarkolli merged commit 8427f52 into master Oct 8, 2019
.NET v3 Board automation moved this from Reviewer approved to Done Oct 8, 2019
@kirankumarkolli kirankumarkolli deleted the users/khdang/linqThenBy branch October 8, 2019 18:07
@atulloh atulloh mentioned this pull request Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@j82w j82w Awaiting requested review from j82w

@bchong95 bchong95 Awaiting requested review from bchong95

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

Assignees

@khdang khdang

Labels
LINQ
Projects
.NET v3 Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khdang @kirankumarkolli @j82w @simplynaveen20