Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Match EditorConfig match Prettier TS file rule #165

Merged
merged 1 commit into from
Oct 26, 2018
Merged

chore: Match EditorConfig match Prettier TS file rule #165

merged 1 commit into from
Oct 26, 2018

Conversation

nschonni
Copy link
Contributor

Noticed in #162 that the EditorConfg and Prettier settings were conflicting, so the IDE was re-indenting TS files that Prettier would then flag in the build

christopheranderson
christopheranderson approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@christopheranderson christopheranderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge once we get our CI back into a healthy state (upstream breaking change we caught early).

@christopheranderson christopheranderson added the engineering engineering improvements (CI, tests, etc.) label Oct 24, 2018
@southpolesteve southpolesteve merged commit b021c98 into Azure:master Oct 26, 2018
@nschonni nschonni deleted the prettier-editorconfig branch October 26, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopheranderson christopheranderson christopheranderson approved these changes

Assignees
No one assigned
Labels
engineering engineering improvements (CI, tests, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nschonni @christopheranderson @southpolesteve