Fixing region fail over issue for direct tcp calls #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
christopheranderson,
David-Noble-at-work,
kushagraThapar and
moderakh
as code owners
simplynaveen20
commented
Aug 27, 2020
gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/ClientRetryPolicy.java
Outdated
Show resolved
Hide resolved
kushagraThapar
requested changes
Aug 27, 2020
.../main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/GatewayAddressCache.java
Show resolved
Hide resolved
gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/ClientRetryPolicy.java
Show resolved
Hide resolved
gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/ClientRetryPolicy.java
Show resolved
Hide resolved
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/CollectionCrudTest.java
Outdated
Show resolved
Hide resolved
|
Discussed the above comments with @simplynaveen20 offline. Good to go from my side. |
kushagraThapar
approved these changes
Aug 28, 2020
moderakh
suggested changes
Aug 28, 2020
commons/src/main/java/com/microsoft/azure/cosmosdb/DocumentClientException.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/com/microsoft/azure/cosmosdb/DocumentClientException.java
Outdated
Show resolved
Hide resolved
gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/ClientRetryPolicy.java
Outdated
Show resolved
Hide resolved
moderakh
reviewed
Aug 28, 2020
commons/src/main/java/com/microsoft/azure/cosmosdb/DocumentClientException.java
Outdated
Show resolved
Hide resolved
moderakh
reviewed
Aug 28, 2020
gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/ClientRetryPolicy.java
Outdated
Show resolved
Hide resolved
moderakh
reviewed
Aug 28, 2020
gateway/src/main/java/com/microsoft/azure/cosmosdb/rx/internal/ClientRetryPolicy.java
Outdated
Show resolved
Hide resolved
moderakh
approved these changes
Aug 28, 2020
Yes as discussed , its not only address resolution, we need to think and change region fail over for all GW calls. |
moderakh
reviewed
Sep 1, 2020
| @@ -323,6 +323,9 @@ | |||
|
|
|||
| // 404: LSN in session token is higher | |||
| public static final int READ_SESSION_NOT_AVAILABLE = 1002; | |||
|
|
|||
| // Client generated gateway network error substatus | |||
| public static final int GATEWAY_ENDPOINT_UNAVAILABLE = 10001; | |||
There was a problem hiding this comment.
we should use a substatus code which doesn't collide with the service side substatus codes otherwise the client-retry-policy will be confused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for tcp network exception we are doing region failover, which is causing problem for some users where due to some intermittent network issue on BE nodes sdk is sending traffic for next 5 min to other available region.
This PR will limit the region failover only in case of http network failure.