Porting region fail over changes from V2 #15233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh and
xinlian12
as code owners
ghost
added
the
simplynaveen20
requested review from
JonathanGiles and
mssfang
as code owners
moderakh
approved these changes
Sep 16, 2020
| request.requestContext.cosmosDiagnostics); | ||
| } | ||
|
|
||
| return Mono.error(dce); |
There was a problem hiding this comment.
you have repeated code here and above method and also seems similar to code block in RxGatewayStoreModel.
for future work consider refactor the common code if that is possible.
| HttpClient httpClient1 = httpClient(false); | ||
| FieldUtils.writeField(addressCache, "httpClient", httpClient1, true); | ||
| } catch (Exception e) { | ||
| fail(e.getMessage()); |
There was a problem hiding this comment.
I suspect this failure/assertion doesn't have any effect as this is happening on a different thread which is not joined.
| assertThat(readResourceResponse.getDiagnostics().toString()).contains("\"errorMessage\":\"io.netty" + | ||
| ".channel.AbstractChannel$AnnotatedConnectException: Connection refused: no further information"); | ||
| } catch (Exception ex) { | ||
| fail("This test should not throw exception"); |
There was a problem hiding this comment.
you don't need to catch exception. and fail. the test will fail regardless of this. if the exception is thrown.
|
/check-enforcer override |
|
/check-enforcer evaulate |
|
/check-enforcer evaluate |
|
/check-enforcer reset |
|
/check-enforcer override |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Aug 31, 2021
Service Bus and EventHub : 2021-06-01-preview - Added optional Properties (Azure#15233) * removing min/max, adding maxMessageSizeInKilobytes to queues and topics * reverted maxSizeInMegabytes type to int32 * fixed the typo * reverted topic maxSizeInMegabytes to int32
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Aug 31, 2021
Service Bus and EventHub : 2021-06-01-preview - Added optional Properties (Azure#15233) * removing min/max, adding maxMessageSizeInKilobytes to queues and topics * reverted maxSizeInMegabytes type to int32 * fixed the typo * reverted topic maxSizeInMegabytes to int32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting below two PRs from V2
Azure/azure-cosmosdb-java#351
Azure/azure-cosmosdb-java#360
Note : It does not have request timeout fix as in V2 Azure/azure-cosmosdb-java#360 , because currently we don't set request time out on http calls in V4 , open issue #13696