-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting region fail over changes from V2 #15233
Porting region fail over changes from V2 #15233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
request.requestContext.cosmosDiagnostics); | ||
} | ||
|
||
return Mono.error(dce); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have repeated code here and above method and also seems similar to code block in RxGatewayStoreModel.
for future work consider refactor the common code if that is possible.
HttpClient httpClient1 = httpClient(false); | ||
FieldUtils.writeField(addressCache, "httpClient", httpClient1, true); | ||
} catch (Exception e) { | ||
fail(e.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this failure/assertion doesn't have any effect as this is happening on a different thread which is not joined.
assertThat(readResourceResponse.getDiagnostics().toString()).contains("\"errorMessage\":\"io.netty" + | ||
".channel.AbstractChannel$AnnotatedConnectException: Connection refused: no further information"); | ||
} catch (Exception ex) { | ||
fail("This test should not throw exception"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to catch exception. and fail. the test will fail regardless of this. if the exception is thrown.
/check-enforcer override |
/check-enforcer evaulate |
/check-enforcer evaluate |
/check-enforcer reset |
/check-enforcer override |
Service Bus and EventHub : 2021-06-01-preview - Added optional Properties (Azure#15233) * removing min/max, adding maxMessageSizeInKilobytes to queues and topics * reverted maxSizeInMegabytes type to int32 * fixed the typo * reverted topic maxSizeInMegabytes to int32
Service Bus and EventHub : 2021-06-01-preview - Added optional Properties (Azure#15233) * removing min/max, adding maxMessageSizeInKilobytes to queues and topics * reverted maxSizeInMegabytes type to int32 * fixed the typo * reverted topic maxSizeInMegabytes to int32
Porting below two PRs from V2
Azure/azure-cosmosdb-java#351
Azure/azure-cosmosdb-java#360
Note : It does not have request timeout fix as in V2 Azure/azure-cosmosdb-java#360 , because currently we don't set request time out on http calls in V4 , open issue #13696