Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting region fail over changes from V2 #15233

Merged

Conversation

simplynaveen20
Copy link
Member

Porting below two PRs from V2
Azure/azure-cosmosdb-java#351
Azure/azure-cosmosdb-java#360

Note : It does not have request timeout fix as in V2 Azure/azure-cosmosdb-java#360 , because currently we don't set request time out on http calls in V4 , open issue #13696

Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

request.requestContext.cosmosDiagnostics);
}

return Mono.error(dce);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have repeated code here and above method and also seems similar to code block in RxGatewayStoreModel.

for future work consider refactor the common code if that is possible.

HttpClient httpClient1 = httpClient(false);
FieldUtils.writeField(addressCache, "httpClient", httpClient1, true);
} catch (Exception e) {
fail(e.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this failure/assertion doesn't have any effect as this is happening on a different thread which is not joined.

assertThat(readResourceResponse.getDiagnostics().toString()).contains("\"errorMessage\":\"io.netty" +
".channel.AbstractChannel$AnnotatedConnectException: Connection refused: no further information");
} catch (Exception ex) {
fail("This test should not throw exception");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to catch exception. and fail. the test will fail regardless of this. if the exception is thrown.

@kushagraThapar
Copy link
Member

/check-enforcer override

@kushagraThapar
Copy link
Member

/check-enforcer evaulate

@kushagraThapar
Copy link
Member

/check-enforcer evaluate

@kushagraThapar
Copy link
Member

/check-enforcer reset

@kushagraThapar
Copy link
Member

/check-enforcer override

@kushagraThapar kushagraThapar merged commit a0b306c into Azure:master Sep 16, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Aug 31, 2021
Service Bus and EventHub : 2021-06-01-preview  - Added optional Properties (Azure#15233)

* removing min/max, adding maxMessageSizeInKilobytes to queues and topics

* reverted maxSizeInMegabytes type to int32

* fixed the typo

* reverted topic maxSizeInMegabytes to int32
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Aug 31, 2021
Service Bus and EventHub : 2021-06-01-preview  - Added optional Properties (Azure#15233)

* removing min/max, adding maxMessageSizeInKilobytes to queues and topics

* reverted maxSizeInMegabytes type to int32

* fixed the typo

* reverted topic maxSizeInMegabytes to int32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants