Improving http request time out avoiding region failover for high latency request #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
christopheranderson,
David-Noble-at-work,
kushagraThapar and
moderakh
as code owners
simplynaveen20
changed the title
simplynaveen20
commented
Sep 11, 2020
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/internal/HttpRequestTimeoutTest.java
Outdated
Show resolved
Hide resolved
moderakh
approved these changes
Sep 14, 2020
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/internal/HttpRequestTimeoutTest.java
Outdated
Show resolved
Hide resolved
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/internal/HttpRequestTimeoutTest.java
Outdated
Show resolved
Hide resolved
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/internal/HttpRequestTimeoutTest.java
Outdated
Show resolved
Hide resolved
...microsoft/azure/cosmosdb/rx/internal/directconnectivity/ClientSideRequestStatisticsTest.java
Outdated
Show resolved
Hide resolved
moderakh
reviewed
Sep 14, 2020
commons/src/main/java/com/microsoft/azure/cosmosdb/ClientSideRequestStatistics.java
Show resolved
Hide resolved
kushagraThapar
requested changes
Sep 14, 2020
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/internal/HttpRequestTimeoutTest.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/com/microsoft/azure/cosmosdb/ClientSideRequestStatistics.java
Show resolved
Hide resolved
mbhaskar
approved these changes
Sep 14, 2020
commons/src/main/java/com/microsoft/azure/cosmosdb/ClientSideRequestStatistics.java
Show resolved
Hide resolved
sdk/src/test/java/com/microsoft/azure/cosmosdb/rx/internal/HttpRequestTimeoutTest.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have an api on ConnectionPolicy setRequestTimeoutInMillis which sets the request time out for both TCP and HTTP requests.
We want to cap the lower value of http client request time out to 60 sec, as http network request call ends up into region fail over and also Gateway does not have any sla.
Note: This PR also contains the improvement on AddressResolutionStatistics in ClientSideRequestStatistics, which include error message if there is any failure on address cache refresh call, also including flag inflightRequest which will indicate whether address call finished in lifetime of the the request.
Also closes query plan issue
closes #359