[azd down] ux updates

cli/azd/cmd/actions/action.go

@@ -38,25 +38,15 @@ type ActionInitializer[T Action] func() (T, error)
 func ToUxItem(actionResult *ActionResult, err error) ux.UxItem {
 	if err != nil {
 		return &ux.ActionResult{
-			SuccessMessage: "",
-			FollowUp:       "",
-			Err:            err,
+			Err: err,
 		}
 	}
 
 	if actionResult == nil {
-		return &ux.ActionResult{
-			SuccessMessage: "",
-			FollowUp:       "",
-			Err:            nil,
-		}
+		return &ux.ActionResult{}
 	}
 	if actionResult.Message == nil {
-		return &ux.ActionResult{
-			SuccessMessage: "",
-			FollowUp:       "",
-			Err:            nil,
-		}
+		return &ux.ActionResult{}
 	}
 	return &ux.ActionResult{
 		SuccessMessage: actionResult.Message.Header,

cli/azd/cmd/down.go

@@ -14,6 +14,7 @@ import (
 	"github.com/azure/azure-dev/cli/azd/pkg/infra/provisioning"
 	"github.com/azure/azure-dev/cli/azd/pkg/input"
 	"github.com/azure/azure-dev/cli/azd/pkg/output"
+	"github.com/azure/azure-dev/cli/azd/pkg/output/ux"
 	"github.com/azure/azure-dev/cli/azd/pkg/project"
 	"github.com/azure/azure-dev/cli/azd/pkg/tools/azcli"
 	"github.com/spf13/cobra"
@@ -97,34 +98,38 @@ func newDownAction(
 }
 
 func (a *downAction) Run(ctx context.Context) (*actions.ActionResult, error) {
-	infraManager, err := provisioning.NewManager(
-		ctx,
-		a.env,
-		a.projectConfig.Path,
-		a.projectConfig.Infra,
-		a.console.IsUnformatted(),
-		a.azCli,
-		a.console,
-		a.commandRunner,
-		a.accountManager,
-		a.userProfileService,
-		a.subResolver,
-		a.alphaFeatureManager,
-	)
-
+	// silent manager for running Plan()
+	infraManager, err := createProvisioningManager(ctx, a, &project.MutedConsole{ParentConsole: a.console})
 	if err != nil {
 		return nil, fmt.Errorf("creating provisioning manager: %w", err)
 	}
 
+	// Command title
+	a.console.MessageUxItem(ctx, &ux.MessageTitle{
+		Title:     "Deleting all resources and deployed code on Azure (azd down)",
+		TitleNote: "Local application code is not deleted when running 'azd down'.",
+	})
+
+	spinnerMsg := "Fetching resources groups."
+	a.console.ShowSpinner(ctx, spinnerMsg, input.Step)
+
 	deploymentPlan, err := infraManager.Plan(ctx)
+	a.console.StopSpinner(ctx, spinnerMsg, input.GetStepResultFormat(err))
+	a.console.Message(ctx, "")
 	if err != nil {
 		return nil, fmt.Errorf("planning destroy: %w", err)
 	}
 
+	// re-create manager with output capabilities to handle output
+	infraManager, err = createProvisioningManager(ctx, a, a.console)
+	if err != nil {
+		return nil, fmt.Errorf("creating provisioning manager: %w", err)
+	}
+
 	destroyOptions := provisioning.NewDestroyOptions(a.flags.forceDelete, a.flags.purgeDelete)
 	destroyResult, err := infraManager.Destroy(ctx, &deploymentPlan.Deployment, destroyOptions)
 	if err != nil {
-		return nil, fmt.Errorf("destroying infrastructure: %w", err)
+		return nil, fmt.Errorf("deleting infrastructure: %w", err)
 	}
 
 	// Remove any outputs from the template from the environment since destroying the infrastructure
@@ -137,7 +142,29 @@ func (a *downAction) Run(ctx context.Context) (*actions.ActionResult, error) {
 		return nil, fmt.Errorf("saving environment: %w", err)
 	}
 
-	return nil, nil
+	return &actions.ActionResult{
+		Message: &actions.ResultMessage{
+			Header: "Your Azure resources have been deleted.",
+		},
+	}, nil
+}
+
+func createProvisioningManager(ctx context.Context, a *downAction, console input.Console) (*provisioning.Manager, error) {
+	infraManager, err := provisioning.NewManager(
+		ctx,
+		a.env,
+		a.projectConfig.Path,
+		a.projectConfig.Infra,
+		a.console.IsUnformatted(),
+		a.azCli,
+		console,
+		a.commandRunner,
+		a.accountManager,
+		a.userProfileService,
+		a.subResolver,
+		a.alphaFeatureManager,
+	)
+	return infraManager, err
 }
 
 func getCmdDownHelpDescription(*cobra.Command) string {

cli/azd/cmd/provision.go

@@ -233,8 +233,9 @@ func (p *provisionAction) Run(ctx context.Context) (*actions.ActionResult, error
 
 	return &actions.ActionResult{
 		Message: &actions.ResultMessage{
-			Header:   "Your project has been provisioned!",
-			FollowUp: getResourceGroupFollowUp(ctx, p.formatter, p.projectConfig, p.resourceManager, p.env),
+			Header: "Your project has been provisioned!",
+			FollowUp: getResourceGroupFollowUp(
+				ctx, p.formatter, p.projectConfig, p.resourceManager, p.env),
 		},
 	}, nil
 }

cli/azd/cmd/up.go

@@ -146,7 +146,6 @@ func (u *upAction) Run(ctx context.Context) (*actions.ActionResult, error) {
 	if err != nil {
 		return nil, err
 	}
-
 	return deployResult, nil
 }