-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use information in .installed-by.txt to advise the user on how to upgrade azd #2177
Conversation
This looks right to me directionally, @danieljurek. I think we should extract some of this logic into an |
Refactor and prose added... updating screenshots above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change - I feel much more comfortable with this UX!
Barring any feedback Austin has, LGTM. 🚀
@Austinauth -- Please have a look at the screenshots. |
@danieljurek in the screenshots for some of them (I think the defaults for Windows, Mac, and Linux) it looks like it is still pointing to a short url specific to that OS that then redirects to the generic install page. Is the expectation that the install docs will have more info for all 3 os's? because that is not the case right now |
My thinking is that we'll write platform-specific install instructions in pages that those short links point to. Once that content is in place we can update those short links to that platform-specific content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the quick fix!
(edit: Wish AI had stopped me from "requesting changes" when the comment says LGTM ;-))
@danieljurek I think commented this somewhere else, but "Warning" needs to be in all caps to be consistent with our current log styling. Otherwise I think everything is good to go.
|
I talked with Daniel about my concern and I feel better about this now. I'll reconfigure the docs content that the links point |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
…rade azd (#2177) * Use information in .installed-by.txt to advise the user on how to upgrade azd * Add additional advise during script usage * Refactor installer package * Remove internal/installed_by.go * Add doc comments to installed_by.go * Add lint ignore comments * Style for warning
Fixes #2176
Windows
install-azd.ps1
winget
choco
default (direct MSI, unknown, etc.)
Linux
install-azd.sh
.rpm/.deb/default
MacOS
brew
install-azd.sh
default