Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change command names and redo grouping and ordering #2190

Merged
merged 7 commits into from
May 12, 2023

Conversation

bwateratmsft
Copy link
Contributor

Fixes #1848

See some screenshots here: #1848 (comment)

@ghost ghost assigned bwateratmsft May 12, 2023
@bwateratmsft bwateratmsft changed the title Change command names and redo ordering Change command names and redo grouping and ordering May 12, 2023
@azure-sdk
Copy link
Collaborator

VSCode Extension Installation Instructions

  1. Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/2190/azure-dev-0.6.0-alpha.1.vsix
  2. Extract the extension from the compressed file
  3. In vscode
    a. Open "Extensions" (Ctrl+Shift+X)
    b. Click the ...\ menu at top of Extensions sidebar
    c. Click "Install from VSIX"
    d. Select location of downloaded file

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had a question about some of the pre-existing uses of "when": "false" but I am expecting the answer is something like "yes, this is dark VS Code Magic that registers these actions somewhere else so they can be used non interactively, as we do from a few places".

ext/vscode/package.json Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit 8eff874 into main May 12, 2023
@bwateratmsft bwateratmsft deleted the bmw/commandNames branch May 16, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Explorer commands look out of place
3 participants