New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for buildArgs
on Docker builds
#2266
Conversation
Adding support for passing `buildArgs` to docker via the azure.yaml file
@aaronpowell Changes looks fine, but I'll probably want to hold this for team input to discuss on #1270 about other considerations of the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great contribution, thank you! Can we update this to support multiple build args?
References
Co-authored-by: Wallace Breza <wallace@breza.me>
Added test for multiple build args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one question about masking build args in logs (fine for us to do in a follow up, if we aren't sure what the right thing is now).
I'll let @wbreza sign off and merge, but it looks good to me.
Thanks for this, @aaronpowell!
This makes it more disconnected from the command line runner so we can use it to redact in other areas. Updated the Docker service to use the redaction method to clean sanitize the buildArgs before logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the requested changes. This version looks great!
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
Fixing #1270
Adding support for passing
buildArgs
to docker via the azure.yaml file