Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for buildArgs on Docker builds #2266

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Support for buildArgs on Docker builds #2266

merged 5 commits into from
Jun 1, 2023

Commits on May 19, 2023

  1. Fixing Azure#1270 

    Adding support for passing `buildArgs` to docker via the azure.yaml file
    @aaronpowell
    aaronpowell committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3892f54 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Wallace Breza <wallace@breza.me>
    @aaronpowell @wbreza
    aaronpowell and wbreza committed May 22, 2023
    Configuration menu
    Copy the full SHA
    706f1ac View commit details
    Browse the repository at this point in the history

  2. Finished refactor for use an array for buildArgs 

    Added test for multiple build args
    @aaronpowell
    aaronpowell committed May 22, 2023
    Configuration menu
    Copy the full SHA
    8d40863 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Moving the redactor function to its own file 

    This makes it more disconnected from the command line runner so we can use it to redact in other areas.

Updated the Docker service to use the redaction method to clean sanitize the buildArgs before logging
    @aaronpowell
    aaronpowell committed May 31, 2023
    Configuration menu
    Copy the full SHA
    092c712 View commit details
    Browse the repository at this point in the history

  2. Fixing lint issue

    @aaronpowell
    aaronpowell committed May 31, 2023
    Configuration menu
    Copy the full SHA
    88a4bd4 View commit details
    Browse the repository at this point in the history