Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing long list issue #647

Merged
merged 1 commit into from
May 30, 2019
Merged

Fixing long list issue #647

merged 1 commit into from
May 30, 2019

Conversation

atbagga
Copy link
Collaborator

@atbagga atbagga commented May 30, 2019 •
edited
Loading

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

I have implemented a pagination list also but during the testing I figured out the exact issue for long list failing was the deinit missing.

Tested using -https://github.com/atbagga/PythonSamples/blob/237be053766d8842b7cf1dd054777fbc41618cf0/prompting.py#L4-L11

@atbagga atbagga merged commit 1238cb5 into master May 30, 2019
@atbagga atbagga deleted the users/atbagga/listissue branch June 3, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitam8 ishitam8 ishitam8 approved these changes

@gauravsaralMs gauravsaralMs gauravsaralMs approved these changes

@geverghe geverghe Awaiting requested review from geverghe

@snankani snankani Awaiting requested review from snankani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atbagga @ishitam8 @gauravsaralMs