Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolately Minimum support for TLS 1.2 #612

Closed
alistairl opened this issue Feb 4, 2020 · 7 comments
Closed

Chocolately Minimum support for TLS 1.2 #612

alistairl opened this issue Feb 4, 2020 · 7 comments

Comments

@alistairl
Copy link

The Chocolately based Windows Artifacts check for and download install.ps1 from https://chocolately.org/install.ps1.

When I ran this recently on Windows Server 2016 it failed with error ERROR: Exception calling "DownloadString" with "1" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."

https://chocolately.org appears to support only TLS 1.2 and TLS 1.3 so I worked around the above by setting the security protocol to TLS 1.2. I did this by applying the following before the download line:

[Net.ServicePointManager]::SecurityProtocol = "tls12"

I'm not raising a pull request as I've not tested this on other Operating Systems and I don't know if there is a better / preferred way to set the protocol.

@marty-macfly
Copy link

Hello,

Same issue for me on a Windows 2012 R2 and your work around is working for me.

@leovms
Copy link
Contributor

leovms commented Feb 4, 2020

Thank you for bringing this up. I'll take a look and update all necessary artifacts.

@leovms
Copy link
Contributor

leovms commented Feb 4, 2020

Please look at PR #613. Let me know if there's anything I may have missed.

@alistairl
Copy link
Author

With my limited tooling that looks awesome. I hadn't noticed that a similar change had to be made last year for other domains. Now that I actually looked there was advance notice at https://chocolatey.org/blog/remove-support-for-old-tls-versions.

Awesome turnaround speed!

@leovms
Copy link
Contributor

leovms commented Feb 4, 2020

@alistairl, we just merged the changes. Can you please check again on your side to make sure the artifact is now behaving as expected?

@marty-macfly
Copy link

It's working for me after your change.

@leovms
Copy link
Contributor

leovms commented Feb 5, 2020

Thank you all.

@leovms leovms closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants