Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestResponseChannel should not throw OperationCancelled on PendingRequests while closing #372

Merged
merged 1 commit into from
Aug 28, 2018
Merged

RequestResponseChannel should not throw OperationCancelled on PendingRequests while closing #372

merged 1 commit into from
Aug 28, 2018

Conversation

SreeramGarlapati
Copy link
Contributor

OperationCancelledException should be used when - a ClientEntity is closed and the corresponding pendingRequests are being cancelled. In this case, an AMQP object is closed and hence, pending requests should be cancelled such that the layers above it can retry.

Close: #366

CC: @sabeegrewal

@SreeramGarlapati SreeramGarlapati merged commit c909102 into Azure:dev Aug 28, 2018
SreeramGarlapati added a commit that referenced this pull request Aug 31, 2018
@SreeramGarlapati
Release commit for package com.microsoft.azure.eventhubs version 1.1.0 (
a49e718 
#375)

* websocket support (#362)
* fix an issue with ExceptionContract - when request-response channel closes with transient error (#372)
* include PartitionReceiver and PartitionSender creation to participate in RetryPolicy (#373)
@SreeramGarlapati SreeramGarlapati mentioned this pull request Aug 31, 2018
Closed
@royyeah royyeah mentioned this pull request Sep 3, 2018
Closed
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati
RequestResponseChannel should not throw OperationCancelled. (#372)
614ead4
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati
Release commit for package com.microsoft.azure.eventhubs version 1.1.0 (
d0d8e3f 
#375)

* websocket support (#362)
* fix an issue with ExceptionContract - when request-response channel closes with transient error (#372)
* include PartitionReceiver and PartitionSender creation to participate in RetryPolicy (#373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkwak sjkwak sjkwak approved these changes

@JamesBirdsall JamesBirdsall Awaiting requested review from JamesBirdsall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OperationCancelledException on RequestResponseChannel close codepaths should be transient
2 participants
@SreeramGarlapati @sjkwak