Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement retry mechanism for Receiver and Sender creation #373

Merged
merged 8 commits into from
Aug 30, 2018
Merged

Implement retry mechanism for Receiver and Sender creation #373

merged 8 commits into from
Aug 30, 2018

Conversation

SreeramGarlapati
Copy link
Contributor

@SreeramGarlapati SreeramGarlapati commented Aug 29, 2018 •
edited
Loading

Close: #29
CC: @sabeegrewal

@SreeramGarlapati
Copy link
Contributor Author

SreeramGarlapati commented Aug 30, 2018 •
edited
Loading

Hello @sabeegrewal - this change is final now. I am trying to get a review from @sjkwak - meanwhile - do you want to go ahead and build a jar out of the PR branch - retryoncreate &

  1. consume this for spark stress runs.
  2. it will be great if you can check - if this is compatible with spark 2.3.1 - in which case - customers dealing with receiver creation - retry issue - MessageSender & MessageReceiver creation should retry upon transient errrors #29 - can consume this immediately - without having to opt into receiver caching - that way it reduces changeset - which inturn reduces risk of running into more issues..

sjkwak
sjkwak reviewed Aug 30, 2018
View reviewed changes
azure-eventhubs/src/main/java/com/microsoft/azure/eventhubs/impl/MessageReceiver.java Outdated
}
} else if (exception instanceof EventHubException && !((EventHubException) exception).getIsTransient()) {
this.cancelOpen(exception);
}
}

synchronized (this.errorConditionLock) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this first and retry on the exception

@SreeramGarlapati SreeramGarlapati merged commit 0648008 into Azure:dev Aug 30, 2018
SreeramGarlapati added a commit that referenced this pull request Aug 31, 2018
@SreeramGarlapati
Release commit for package com.microsoft.azure.eventhubs version 1.1.0 (
a49e718 
#375)

* websocket support (#362)
* fix an issue with ExceptionContract - when request-response channel closes with transient error (#372)
* include PartitionReceiver and PartitionSender creation to participate in RetryPolicy (#373)
@SreeramGarlapati SreeramGarlapati mentioned this pull request Aug 31, 2018
Closed
@royyeah royyeah mentioned this pull request Sep 3, 2018
Closed
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati
Implement retry mechanism for Receiver and Sender creation (#373)
dd16e46 
* msgreceiver creation - retry on transient errors
* messagesender creation retry
* always throw TimeoutException on transient failures
* throw schedulererrors to usercode
* verify retry invocation in unittests
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati
Release commit for package com.microsoft.azure.eventhubs version 1.1.0 (
d0d8e3f 
#375)

* websocket support (#362)
* fix an issue with ExceptionContract - when request-response channel closes with transient error (#372)
* include PartitionReceiver and PartitionSender creation to participate in RetryPolicy (#373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkwak sjkwak sjkwak approved these changes

@JamesBirdsall JamesBirdsall Awaiting requested review from JamesBirdsall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SreeramGarlapati @sjkwak