Update unzipper npm package to resolve unzip issue during installation #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ahmelsayed
approved these changes
Feb 7, 2020
|
Thanks @ronbrogan |
|
@ankitkumarr can we pull this change into the v3.x branch as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue installing tools on a fresh install where the install script would fail silently before the download of "https://functionscdn.azureedge.net/public/2.4.290/Azure.Functions.Cli.win-x64.2.4.290.zip" would even start. Looking at the unzipper library that is used, I saw that a fix for the issue was merged here:
ZJONSSON/node-unzipper#169
This issue has similar symptoms to what I experienced, so this may be a fix for that as well:
#1804