Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Tools .NET 9 Changes #3764

Merged
merged 26 commits into from
Jul 31, 2024
Merged

Core Tools .NET 9 Changes #3764

merged 26 commits into from
Jul 31, 2024

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Jul 12, 2024

Issue describing the changes in this PR

resolves #2560

Adding .NET 9 support for the func init command by adding .NET 9 as a supported TFM
When released, this commit should be released with the following changes as well:

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@aishwaryabh aishwaryabh marked this pull request as ready for review July 16, 2024 20:37
@aishwaryabh aishwaryabh requested a review from a team as a code owner July 16, 2024 20:37
@kshyju
Copy link
Member

kshyju commented Jul 22, 2024

Let's ensure that the following two use cases are functioning correctly for net9.0.

  1. The init action works for Docker file use case.

    func init --worker-runtime dotnet-isolated --target-framework net9.0 --docker
  2. The publish action is also working.

@aishwaryabh
Copy link
Contributor Author

Followed up with Shyju regarding testing out dockerfile and publish command and we will address that in this issue once the linux images have been published: Docker images for .NET 9 - Core tools · Issue #2590 · Azure/azure-functions-dotnet-worker (github.com)

pipelineUtilities.psm1 Show resolved Hide resolved
test/Azure.Functions.Cli.Tests/E2E/StartTests.cs Outdated Show resolved Hide resolved
test/Azure.Functions.Cli.Tests/E2E/StartTests.cs Outdated Show resolved Hide resolved
@aishwaryabh aishwaryabh requested a review from kshyju July 30, 2024 21:53
@aishwaryabh aishwaryabh merged commit 9a45cff into v4.x Jul 31, 2024
9 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/net9 branch July 31, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Tools updates for .NET 9
2 participants