Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventHubTrigger sample by setting IsBatched=false #1633

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jun 14, 2023

The sample project does not build as the function EventDataWithStringPropertiesFunction is in error:

Failed to generate function metadata from WorkerBindingSamples.dll: Failed to generate metadata for function 'EventDataWithStringPropertiesFunction' (method 'System.Void SampleApp.EventDataSamples::EventDataWithStringPropertiesFunction(Azure.Messaging.EventHubs.EventData,System.String,System.Int64)'): Function is configured to process events in batches but parameter type is not iterable. Change parameter named 'event' to be an IEnumerable type or set 'IsBatched' to false on your 'EventHubTrigger' attribute. [/Users/likasem/source/functions/azure-functions-dotnet-worker/samples/WorkerBindingSamples/WorkerBindingSamples.csproj]

Setting IsBatched = false on that sample to fix this issue.

Also fixing failed tests.

@aishwaryabh aishwaryabh merged commit aab0112 into feature/sdk-type-binding Jun 14, 2023
21 checks passed
@aishwaryabh aishwaryabh deleted the lk/fix-sample branch June 14, 2023 22:41
liliankasem added a commit that referenced this pull request Jun 21, 2023
* Set IsBatched

* fix tests

* fixing test again!

---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jun 22, 2023
* Set IsBatched

* fix tests

* fixing test again!

---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 21, 2023
---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 24, 2023
---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
JoshLove-msft pushed a commit to JoshLove-msft/azure-functions-dotnet-worker that referenced this pull request Oct 4, 2023
* Set IsBatched

* fix tests

* fixing test again!

---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants