Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor worker extension converters #1716

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Refactor worker extension converters #1716

merged 4 commits into from
Jul 7, 2023

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jul 5, 2023 •
edited

Issue describing the changes in this PR

resolves #1703

Refactoring converters for consistency on how we deal with unhandled vs failed cases, and in the type of exceptions we throw

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@liliankasem liliankasem linked an issue Jul 5, 2023 that may be closed by this pull request
Cleanup worker extensions for consistency in handling failed vs unhandled #1703
Closed
liliankasem and others added 2 commits July 6, 2023 11:18
@liliankasem @jviau
Update extensions/Worker.Extensions.Storage.Queues/src/TypeConverters…
fe2fa86 
…/QueueConverterBase.cs

Co-authored-by: Jacob Viau <javia@microsoft.com>
@liliankasem
PR feedback
3cf8cf0
@liliankasem liliankasem requested a review from jviau July 6, 2023 20:31
@liliankasem liliankasem merged commit efd78f1 into feature/sdk-type-binding Jul 7, 2023
21 checks passed
@liliankasem liliankasem deleted the liliankasem/refactor-converters branch July 7, 2023 16:15
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
b786013
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
8741acd
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
bc9e15e
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
a727c83
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
1dc6535
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
423ede9
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor worker extension converters (#1716)
e489530
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Refactor worker extension converters (#1716)
30714f5
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Refactor worker extension converters (#1716)
cb44d98
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Move shared code to Extensions.Shared project (#1716)
c712b41
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Move shared code to Extensions.Shared project (#1716)
cc11a73
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Move shared code to Extensions.Shared project (#1716)
2484229
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Refactor worker extension converters (#1716)
8eab78d
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Refactor EventGrid worker extension converter (#1716)
e71bdf1
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Move shared code to Extensions.Shared project (#1716)
e55a5fe
liliankasem added a commit that referenced this pull request Jul 20, 2023
@liliankasem
Move shared code to Extensions.Shared project (#1716)
bbf7bf6
liliankasem added a commit that referenced this pull request Jul 20, 2023
@liliankasem
Refactor EventGrid worker extension converter (#1716)
d613b6e
liliankasem added a commit that referenced this pull request Jul 20, 2023
@liliankasem
Refactor cosmos worker extension converter (#1716)
0e4aaa5
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem @aishwaryabh
Update EventHub converter and unit tests (#1633, #1716, #1723, #1742)
e56a244 
---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
f3d099a 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
ee372e2
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor CosmosDB converter, samples, and attributes (#1606, #1716, #…
20b1f9f 
…1695)
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
c763272
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
5b48045 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem @aishwaryabh
Update EventHub converter and unit tests (#1633, #1716, #1723, #1742)
aec4408 
---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
3dd47b6 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
93ceef1 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 25, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
b9b2134 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 25, 2023
@liliankasem
Refactor CosmosDB converter, samples, and attributes (#1606, #1716, #…
71121a9 
…1695)
liliankasem added a commit that referenced this pull request Jul 25, 2023
@liliankasem
Refactor CosmosDB converter, samples, and attributes (#1606, #1716, #…
4805c38 
…1695)
liliankasem added a commit that referenced this pull request Jul 25, 2023
@liliankasem
Refactor CosmosDB converter, samples, and attributes (#1606, #1716, #…
6194fa5 
…1695)
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
1e2bb21
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
4004f4c
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
d78a268
liliankasem added a commit that referenced this pull request Jul 31, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
39bf886
liliankasem added a commit that referenced this pull request Aug 1, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
0ee7856
liliankasem added a commit that referenced this pull request Aug 1, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
f89ff7d
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3ff541a
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
d3fb6a7
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
d77c70e
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3c485ce
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
9eba5d6
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
7819b98
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
7b07011
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
5f6baa0
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
95d8d4a
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
5230add
JoshLove-msft pushed a commit to JoshLove-msft/azure-functions-dotnet-worker that referenced this pull request Oct 4, 2023
@liliankasem @JoshLove-msft
Refactor worker extension converters (Azure#1716)
1bf8fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup worker extensions for consistency in handling failed vs unhandled
2 participants
@liliankasem @jviau