Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and fix unit tests #1727

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Update and fix unit tests #1727

merged 5 commits into from
Jul 10, 2023

Conversation

liliankasem
Copy link
Member

  • Update a couple tests that were missed when converter behaviour was changed (in how we handle invalid content source and content type)
  • Refactored Table unit tests
  • Refactored EventGrid unit tests

aishwaryabh
aishwaryabh approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@aishwaryabh aishwaryabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for refactoring the table and event grid tests :)

@liliankasem liliankasem merged commit 52399c5 into feature/sdk-type-binding Jul 10, 2023
23 checks passed
@liliankasem liliankasem deleted the liliankasem/fix-unit-tests branch July 10, 2023 20:15
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Update and fix unit tests (#1727)
7c030dd
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Update and fix unit tests (#1727)
a14ee91
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Update and fix unit tests (#1727)
ff4541e
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Update and fix unit tests (#1727)
46273d8
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Update and fix unit tests (#1727)
55f6aba
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Update and fix unit tests (#1727)
d75e70b
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Update and fix unit tests (#1727)
d8c00ae
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Refactor EventGrid extension unit tests (#1727)
7a201d9
liliankasem added a commit that referenced this pull request Jul 20, 2023
@liliankasem
Refactor EventGrid extension unit tests (#1727)
ee48260
liliankasem added a commit that referenced this pull request Jul 20, 2023
@liliankasem
Refactor EventGrid extension converter, tests, and samples (#1695, #1716
453c565 
, #1727, #1723)
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor EventGrid extension converter, tests, and samples (#1695, #1716
67b642a 
, #1727, #1723)
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3533b94
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
cc23664
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
206e18b
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
ee372e2
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
c763272
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
1e2bb21
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
4004f4c
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
d78a268
liliankasem added a commit that referenced this pull request Jul 31, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
39bf886
liliankasem added a commit that referenced this pull request Aug 1, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
0ee7856
liliankasem added a commit that referenced this pull request Aug 1, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
f89ff7d
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3ff541a
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
d3fb6a7
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
d77c70e
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3c485ce
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
9eba5d6
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
7819b98
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
7b07011
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
5f6baa0
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
95d8d4a
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
5230add
JoshLove-msft pushed a commit to JoshLove-msft/azure-functions-dotnet-worker that referenced this pull request Oct 4, 2023
@liliankasem @JoshLove-msft
Update and fix unit tests (Azure#1727)
9e907c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aishwaryabh aishwaryabh aishwaryabh approved these changes

@surgupta-msft surgupta-msft Awaiting requested review from surgupta-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liliankasem @aishwaryabh