Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide batch position and size information inside entity operations #1511

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

sebastianburckhardt
Copy link
Collaborator

Adds two properties to IDurableEntityContext:

        /// <summary>
        /// The size of the current batch of operations.
        /// </summary>
        int BatchSize { get; }

        /// <summary>
        /// The position of the currently executing operation within the current batch of operations.
        /// </summary>
        int BatchPosition { get; }

as discussed in #1456.

@sebastianburckhardt sebastianburckhardt added this to the Extension v.2.4.0 milestone Nov 12, 2020
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmrdavid, let's file issues against the Durable JS and Durable Python repos to add this, as it should be very straightforward.

@davidmrdavid
Copy link
Contributor

This is pretty cool! I'll file the issues @ConnorMcMahon and link them here

@davidmrdavid
Copy link
Contributor

davidmrdavid commented Nov 20, 2020

JS: Azure/azure-functions-durable-js#226
Python: Azure/azure-functions-durable-python#227

Also, funny how the issue numbers between the two repos are almost in sync haha. 227 and 226, interesting....

@sebastianburckhardt sebastianburckhardt merged commit d083827 into dev Nov 20, 2020
@sebastianburckhardt sebastianburckhardt deleted the sebastian/provide-batch-information branch November 20, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants