Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Eliminate string allocation for LatencyEvent #8013

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

NickCraver
Copy link
Member

This eliminates a string we allocate each time but is easily removed. Importantly though, this might break an existing query by correcting the JSON - needs eyes to see if this would be the case. I'm not sure who to ask on usage here and if there's a reason to maintain the incorrect format, but happy to amend if so!

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

This eliminates a string we allocate each time but is easily removed. Importantly though, this might break an existing query by correcting the JSON - needs eyes to see if this would be the case. I'm not sure who to ask on usage here and if there's a reason to maintain the incorrect format, but happy to amend if so!
@NickCraver
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NickCraver NickCraver merged commit da99880 into dev Jan 11, 2022
@NickCraver NickCraver deleted the craver/metricslogger-allocations branch January 11, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants