Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure v4 model compatibility with Static Web Apps #80

Closed
ejizba opened this issue Apr 11, 2023 · 9 comments
Closed

Ensure v4 model compatibility with Static Web Apps #80

ejizba opened this issue Apr 11, 2023 · 9 comments
Assignees
Labels
GA blocker investigate v4 🚀 We no longer use this label since v4 is now the default model.

Comments

@ejizba
Copy link
Contributor

ejizba commented Apr 11, 2023

This should hopefully "just work", but we should test some end-to-end static web app scenarios before GA.

@ejizba ejizba added v4 🚀 We no longer use this label since v4 is now the default model. investigate GA blocker labels Apr 11, 2023
@ejizba ejizba added this to the Backlog Candidates milestone Apr 11, 2023
@diberry
Copy link

diberry commented Apr 24, 2023

@ejizba
Copy link
Contributor Author

ejizba commented Jun 20, 2023

I tried this today. I put up a PR to fix the VS Code problems here: microsoft/vscode-azurefunctions#3721

The other problem is you can't set AzureWebJobsFeatureFlags to EnableWorkerIndexing in SWA, but the flag requirement is going away - it just hasn't made it to all regions yet. I tested in West US 2 and got it working.

@ejizba ejizba modified the milestones: Backlog Candidates, June 2023 Jun 21, 2023
@offbeatful
Copy link

Nice to see some traction here! When is it expected to work without the flag?

@ejizba
Copy link
Contributor Author

ejizba commented Jun 26, 2023

Like I said it's already rolled out in some regions - you can use "West US 2" today. For the rest of the regions, I would guess we finish in the next month or so.

@offbeatful
Copy link

offbeatful commented Jun 27, 2023

Yes, I can confirm it is working in West US 2. Thank you!

@ejizba ejizba self-assigned this Jul 24, 2023
@ejizba ejizba modified the milestones: June 2023, August 2023 Aug 10, 2023
@ejizba ejizba modified the milestones: August 2023, September 2023 Sep 5, 2023
@ejizba
Copy link
Contributor Author

ejizba commented Sep 20, 2023

The flag should be enabled by default in all regions at this point

@ejizba ejizba closed this as completed Sep 20, 2023
@feuersteiner
Copy link

sorry to comment here.

I am having trouble running functions v4 (typescript) with SWA cli (the cli is only compatible at node <=16, and the functions node >=18). I haven't reached the deployment problem just yet ... because the whole thing is not running on my local machine. is there a blog post on this? best practices? because for now, it feels like a little bit disorienting to not find any documentation about this transition. Thanks again for the effort!

@ejizba
Copy link
Contributor Author

ejizba commented Oct 11, 2023

@feuersteiner I think the swa cli is supposed to work with Node18 now. See their v1.1.4 release and this issue for details. You definitely need node 18 to work with the new model, so if you can't get node 18 working with the swa cli I'd recommend following up in their repo

@feuersteiner
Copy link

@feuersteiner I think the swa cli is supposed to work with Node18 now. See their v1.1.4 release and this issue for details. You definitely need node 18 to work with the new model, so if you can't get node 18 working with the swa cli I'd recommend following up in their repo

thanks a lot for your message @ejizba !! was easy to get lost in outdated documentation (even on the site of the sea-cli stating that it only supports <=16).
Tried what you said on a fresh node 18 install and it worked like a charm 🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GA blocker investigate v4 🚀 We no longer use this label since v4 is now the default model.
Projects
None yet
Development

No branches or pull requests

4 participants