Fix SWA create function for node model v4 #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
approved these changes
Jun 21, 2023
| @@ -39,11 +40,11 @@ export function getScriptVerifiedTemplateIds(version: string): (string | RegExp) | |||
| // These languages are only supported in v2+ - same functions as JavaScript, with a few minor exceptions that aren't worth distinguishing here | |||
| // NOTE: The Python Preview IDs are only temporary. | |||
| // NOTE: The Node Programming Model IDs include -4.x as a suffix | |||
| const regExps = verifiedTemplateIds.map(t => new RegExp(`^${t}-(JavaScript(-4.x)?|TypeScript(-4.x)?|Python|PowerShell|Custom|Python-Preview|Python-Preview-Append)$`, 'i')); | |||
| const regExps = verifiedTemplateIds.map(t => new RegExp(`^${t}-(JavaScript(${nodeV4Suffix})?|TypeScript(${nodeV4Suffix})?|Python|PowerShell|Custom|Python-Preview|Python-Preview-Append)$`, 'i')); | |||
There was a problem hiding this comment.
Template strings in a regular expression? You're braver than me. 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When picking the template based on a templateId (which is how SWA creates a function here), the functions extension always uses the v3 template even if v4 was selected by the user. I adjusted the filtering in
FunctionListStepbut it didn't quite work because we were callingFunctionListStep.createbefore the model prompt. I switched to use the fancy newconfigureBeforePromptmethod which selects the template after the model prompt and worked for me.Fixes microsoft/vscode-azurestaticwebapps#829