Add options to invocation context #54
Conversation
| @@ -53,6 +54,7 @@ export class InvocationModel implements coreTypes.InvocationModel { | |||
| retryContext: fromRpcRetryContext(req.retryContext), | |||
| traceContext: fromRpcTraceContext(req.traceContext), | |||
| triggerMetadata: fromRpcTriggerMetadata(req.triggerMetadata, this.#triggerType), | |||
| options: fromRpcBindings(this.#bindings), | |||
There was a problem hiding this comment.
My biggest issue with this implementation is that this now requires the options as input to the constuctor of InvocationContext, making the unit testing scenario harder. This code you have in the Wiki here would no longer work:
const testInvocationContext = new InvocationContext({
functionName: 'testFunctionName',
invocationId: 'testInvocationId',
logHandler: (_level, ...args) => console.log(...args)
});Is there a way around this? Could we have the options object initialized inside the constructor, or set here after the context = new InvocationContext({}) line?
There was a problem hiding this comment.
I assume this feedback applies to all properties on InvocationContextInit? I've updated so in testing scenarios you can just do new InvocationContext()
There was a problem hiding this comment.
That's great! Yeah, I was gonna suggest that too but in a separate PR 😛
| @@ -53,6 +54,7 @@ export class InvocationModel implements coreTypes.InvocationModel { | |||
| retryContext: fromRpcRetryContext(req.retryContext), | |||
| traceContext: fromRpcTraceContext(req.traceContext), | |||
| triggerMetadata: fromRpcTriggerMetadata(req.triggerMetadata, this.#triggerType), | |||
| options: fromRpcBindings(this.#bindings), | |||
There was a problem hiding this comment.
That's great! Yeah, I was gonna suggest that too but in a separate PR 😛
Fixes #52
The main goal is just to give people an easy way to inspect the configuration they used to register the function at the time of invocation.