-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pipeline to run E2E tests for ooproc #30
Conversation
try providing model name like it is done in in proc sample to run these tests - https://github.com/Azure/azure-functions-openai-extension/blob/main/samples/chat/csharp-inproc/ChatBot.cs#L43C8-L43C113 the tests run on Azure Open AI, it expects the deployment name as model name. verify the docker run and test (commands available in the pipeline), you would need docker desktop to build the image, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see this! A few minor questions/comments below.
src/Functions.Worker.Extensions.OpenAI/Functions.Worker.Extensions.OpenAI.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small blocker for me to make it easier for users to successfully run the sample.
Resolves: https://github.com/Azure/azure-functions-pyfx-planning/issues/151
This PR addresses running the E2E tests for the chat completion dotnet isolated scenario. In order for isolated to work, the worker needs to build its own local package of web jobs to pick up the latest changes. The pipeline creates a test package called
Microsoft.Azure.WebJobs.Extensions.OpenAI.99.99.99-test.nupkg
and puts it into a local feed calledNuGetPackagesLocal
. The worker then consumes these changes and runs the E2E tests as expected.I also removed the in-proc sample project and tests for chat completion, since going forward we would want users to only use the isolated model.