Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pipeline to run E2E tests for ooproc #30

Merged
merged 119 commits into from
Feb 28, 2024

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Feb 21, 2024

Resolves: https://github.com/Azure/azure-functions-pyfx-planning/issues/151

This PR addresses running the E2E tests for the chat completion dotnet isolated scenario. In order for isolated to work, the worker needs to build its own local package of web jobs to pick up the latest changes. The pipeline creates a test package called Microsoft.Azure.WebJobs.Extensions.OpenAI.99.99.99-test.nupkg and puts it into a local feed called NuGetPackagesLocal. The worker then consumes these changes and runs the E2E tests as expected.

I also removed the in-proc sample project and tests for chat completion, since going forward we would want users to only use the isolated model.

@manvkaur
Copy link
Collaborator

manvkaur commented Feb 21, 2024

try providing model name like it is done in in proc sample to run these tests - https://github.com/Azure/azure-functions-openai-extension/blob/main/samples/chat/csharp-inproc/ChatBot.cs#L43C8-L43C113

the tests run on Azure Open AI, it expects the deployment name as model name.

verify the docker run and test (commands available in the pipeline), you would need docker desktop to build the image,
in your local system with three keys and their values in local.settings.json -
"AZURE_OPENAI_KEY": "",
"AZURE_OPENAI_ENDPOINT": "",
"AZURE_DEPLOYMENT_NAME": ""

Copy link
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see this! A few minor questions/comments below.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
samples/chat/csharp-ooproc/ChatBotIsolated.cs Show resolved Hide resolved
samples/chat/csharp-ooproc/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@manvkaur manvkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small blocker for me to make it easier for users to successfully run the sample.

samples/chat/README.md Outdated Show resolved Hide resolved
@aishwaryabh aishwaryabh merged commit 2e97e1d into main Feb 28, 2024
2 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/update-pipeline-ooproc-tests branch February 28, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants