Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the pipeline to ADO to allow runs from fork #32

Merged
merged 28 commits into from
Feb 28, 2024
Merged

Move the pipeline to ADO to allow runs from fork #32

merged 28 commits into from
Feb 28, 2024

Conversation

manvkaur
Copy link
Collaborator

@manvkaur manvkaur commented Feb 22, 2024 •
edited

Move the PR and CI build to ADO to allow runs from forks with a comment from maintainer

Possible conflict with #30

@manvkaur manvkaur changed the title add condition to run the tests on github action Update PR build with a condition for PRs from fork Feb 22, 2024
@manvkaur manvkaur marked this pull request as ready for review February 22, 2024 17:20
@manvkaur manvkaur changed the title Update PR build with a condition for PRs from fork Update PR tests step with a condition for PRs from fork Feb 22, 2024
@manvkaur manvkaur marked this pull request as draft February 27, 2024 13:49
@manvkaur manvkaur removed the request for review from cgillum February 27, 2024 13:49
@manvkaur manvkaur marked this pull request as ready for review February 27, 2024 21:53
@manvkaur manvkaur changed the title Update PR tests step with a condition for PRs from fork Move the pipeline to ADO to allow runs from fork Feb 27, 2024
cgillum
cgillum reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one suggestion below. Also, I think we should wait to merge this after merging @aishwaryabh's PR.

build/build-pr-ci.yml Outdated Show resolved Hide resolved
@manvkaur manvkaur merged commit 2de49f9 into main Feb 28, 2024
2 checks passed
@manvkaur manvkaur deleted the manvkaur/updategithubaction branch February 28, 2024 12:59
@manvkaur
Copy link
Collaborator Author

Addressing https://github.com/Azure/azure-functions-pyfx-planning/issues/195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

@aishwaryabh aishwaryabh Awaiting requested review from aishwaryabh aishwaryabh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manvkaur @cgillum