Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with DocumentHelperExceptions.GetOpenApiParameters not forwarding the OpenAPI schema version. #503

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

jstoker
Copy link
Contributor

@jstoker jstoker commented Oct 27, 2022

When generating an OpenAPI v3 Schema with [OpenApiParameter(Example = ...)], the generated schema includes the following, which does not quite validate successfully.

example: 1
examples:
 - 1

To quote the OpenAPI Schema 3.0.1 specification: The example field is mutually exclusive of the examples field.

@jstoker jstoker force-pushed the jstoker/openapi-parameter-examples-v3 branch from 3f9279e to ed1faa3 Compare November 21, 2022 12:06
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstoker Thanks for the good catch!

@justinyoo justinyoo added bug Something isn't working v1.6.0 labels Jan 16, 2023
@justinyoo justinyoo added this to the Release 2023Q1 - v1.6.0 milestone Jan 16, 2023
@justinyoo justinyoo merged commit 5a64b15 into Azure:main Jan 16, 2023
@justinyoo justinyoo added v1.5.1 and removed v1.6.0 labels Jan 26, 2023
Derich367 pushed a commit to Derich367/azure-functions-openapi-extension that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.5.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants