Nugetize

[TylerLeonhardt]

This nugetizes the worker so that another project can bring it in via nuget package.

also fixes a test

[TylerLeonhardt]

After dotnet build

The resulting nupkg looks right:

nuspec:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
  <metadata>
    <id>Azure.Functions.PowerShell.Worker</id>
    <version>0.1.0</version>
    <title>Azure Function PowerShell Language Worker</title>
    <authors>Microsoft</authors>
    <owners>Microsoft</owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <licenseUrl>https://github.com/Azure/azure-functions-powershell-worker/blob/dev/LICENSE</licenseUrl>
    <projectUrl>https://github.com/Azure/azure-functions-powershell-worker</projectUrl>
    <iconUrl>https://github.com/PowerShell/PowerShell/blob/master/assets/Powershell_64.png</iconUrl>
    <description>The Azure Function PowerShell Language Worker allows users to write Azure Function Apps using PowerShell. It leverages the PowerShell Core SDK.</description>
    <releaseNotes># 0.1.0

    Initial Release</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <tags>azure,functions,powershell,worker</tags>
    <dependencies>
      <group targetFramework=".NETCoreApp2.1">
        <dependency id="CommandLineParser" version="2.3.0" exclude="Build,Analyzers" />
        <dependency id="Google.Protobuf" version="3.6.1" exclude="Build,Analyzers" />
        <dependency id="Grpc" version="1.14.1" exclude="Build,Analyzers" />
        <dependency id="Microsoft.NETCore.App" version="2.1.0" exclude="Build,Analyzers" />
        <dependency id="Microsoft.PowerShell.SDK" version="6.1.0-rc.1" exclude="Build,Analyzers" />
        <dependency id="Newtonsoft.Json" version="11.0.2" exclude="Build,Analyzers" />
      </group>
    </dependencies>
    <contentFiles>
      <files include="any/netcoreapp2.1/worker.config.json" buildAction="Content" />
      <files include="any/netcoreapp2.1/Modules/Azure.Functions.PowerShell.Worker.Module/Azure.Functions.PowerShell.Worker.Module.psd1" buildAction="Content" />
      <files include="any/netcoreapp2.1/Modules/Azure.Functions.PowerShell.Worker.Module/Azure.Functions.PowerShell.Worker.Module.psm1" buildAction="Content" />
    </contentFiles>
  </metadata>
</package>

Directory structure:

There's one strange thing I can't figure out... Why the worker.config.json file, and the helper PowerShell module aren't being copied to the Publish folder when you add the newly generated nuget package to a random other .net project.

I used this example to test...
https://github.com/dasMulli/LocalNupkgExample

I added the nugetized worker to this project and then did a dotnet publish.

Tylers-MacBook-Pro:testProj tyler$ ls bin/Debug/netcoreapp2.1/publish/
Azure.Functions.PowerShell.Worker.dll		System.Data.SqlClient.dll			System.Security.Permissions.dll
CommandLine.dll					System.Diagnostics.EventLog.dll			System.ServiceModel.Duplex.dll
Google.Protobuf.dll				System.Diagnostics.PerformanceCounter.dll	System.ServiceModel.Http.dll
Grpc.Core.dll					System.DirectoryServices.AccountManagement.dll	System.ServiceModel.NetTcp.dll
Markdig.dll					System.DirectoryServices.Protocols.dll		System.ServiceModel.Primitives.dll
Microsoft.ApplicationInsights.dll		System.DirectoryServices.dll			System.ServiceModel.Security.dll
Microsoft.CodeAnalysis.CSharp.dll		System.Drawing.Common.dll			System.ServiceModel.Syndication.dll
Microsoft.CodeAnalysis.dll			System.IO.Packaging.dll				System.ServiceModel.dll
Microsoft.Win32.Registry.AccessControl.dll	System.IO.Ports.dll				System.ServiceProcess.ServiceController.dll
Microsoft.Win32.SystemEvents.dll		System.Interactive.Async.dll			System.Text.Encoding.CodePages.dll
NJsonSchema.dll					System.Management.dll				System.Text.Encodings.Web.dll
Newtonsoft.Json.dll				System.Net.Http.WinHttpHandler.dll		System.Threading.AccessControl.dll
System.CodeDom.dll				System.Runtime.Caching.dll			runtimes
System.ComponentModel.Composition.dll		System.Runtime.CompilerServices.Unsafe.dll	testProj.deps.json
System.Configuration.ConfigurationManager.dll	System.Security.Cryptography.Pkcs.dll		testProj.dll
System.Data.DataSetExtensions.dll		System.Security.Cryptography.ProtectedData.dll	testProj.pdb
System.Data.Odbc.dll				System.Security.Cryptography.Xml.dll		testProj.runtimeconfig.json

For some reason, all the dlls are in there but none of the other assets I mentioned before... I don't know why

[TylerLeonhardt]

@SteveL-MSFT + @daxian-dbw and idea? or any idea who is knowledgeable on nuget packages?

[daxian-dbw]

@tylerl0706 You can take a look at the layout of PowerShellHelpFiles and PSDesiredConfiguration packages. Their content can be deployed to our publish folder without problem:

https://powershell.myget.org/feed/powershell-core/package/nuget/PowerShellHelpFiles
https://powershell.myget.org/feed/powershell-core/package/nuget/PSDesiredStateConfiguration

[TylerLeonhardt]

Ok fixed it. We needed to add PackageCopyToOutput="true" to the Content tags. Removing WIP.

Please review @daxian-dbw :)

[daxian-dbw]

Shall we do the renaming (from Azure.Functions.PowerShell.Worker to Microsoft.Azure.Functions.PowerShellWorker) in this repo before publishing NuGet package?

Not necessarily be done in this PR. I think it's better to do it after merging this PR.

[TylerLeonhardt]

Yeah I agree. We should see what the other language workers are called and try to be consistent.

[daxian-dbw]

<Company> and <CopyRight> tags are included in the package.props, but the <Product> tag probably should be kept?

[TylerLeonhardt]

added.

[daxian-dbw]

Yay!! 💯