Kafka Trigger Rich Type #13
Conversation
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def timestamp(self) -> typing.Optional[str]: |
There was a problem hiding this comment.
Wouldn't it be better to have this as datetime.datetime rather than str?
| return self.__topic | ||
|
|
||
| @property | ||
| def timestamp(self) -> typing.Optional[str]: |
There was a problem hiding this comment.
Same as above. Better to have this as datetime.datetime?
There was a problem hiding this comment.
If I keep this as datetime, depending on the format used by the sender, the trigger conversion fails. So its best to not handle the variety of datetimes and keep it as string. This also applies to the event hub trigger.
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def key(self) -> typing.Optional[str]: |
There was a problem hiding this comment.
This should be decorated with @property as well. Same applies for the properties below this as well since they do not follow method conventions.
|
Closing this PR. Please submit a new PR to https://github.com/Azure/azure-functions-kafka-extension |
Supporting rich type KafkaEvent for KafkaTrigger in Python
Azure/azure-functions-kafka-extension#10