-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Trigger Rich Type #389
Conversation
return _kafka.KafkaEvent( | ||
body=body, | ||
timestamp=cls._decode_trigger_metadata_field( | ||
trigger_metadata, 'Timestamp', python_type=str), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned in Azure/azure-functions-python-library#13 as well. Keep this as datetime.datetime
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the different kinds of datetime formats that arrive and there is no specification on what should be a time format, I thought its best to leave it as string and allow folks to convert the way they want it.
@priyaananthasankar, looks good to me overall. Once #398 is checked in and released, would be better to check this change into the Kafka extensions repo. You can include the entry point into the |
@maiqbal11 - Can we get a release for the python worker? |
@pragnagopa, I'll start the release. |
Implemented in Azure/azure-functions-kafka-extension#92 |
Supporting rich type KafkaEvent for KafkaTrigger in Python
Azure/azure-functions-kafka-extension#10