Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Trigger Rich Type #389

Closed

Conversation

priyaananthasankar
Copy link

Supporting rich type KafkaEvent for KafkaTrigger in Python
Azure/azure-functions-kafka-extension#10

return _kafka.KafkaEvent(
body=body,
timestamp=cls._decode_trigger_metadata_field(
trigger_metadata, 'Timestamp', python_type=str),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in Azure/azure-functions-python-library#13 as well. Keep this as datetime.datetime?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the different kinds of datetime formats that arrive and there is no specification on what should be a time format, I thought its best to leave it as string and allow folks to convert the way they want it.

@maiqbal11
Copy link
Contributor

@priyaananthasankar, looks good to me overall. Once #398 is checked in and released, would be better to check this change into the Kafka extensions repo. You can include the entry point into the setup.py for the kafka trigger package. This would be a cleaner way of just collecting all the kafka extension related code in one place (this is a more general pattern we are recommending). \cc @pragnagopa

@pragnagopa
Copy link
Member

@maiqbal11 - Can we get a release for the python worker?
@priyaananthasankar - As @maiqbal11 mentioned please move this PR to https://github.com/Azure/azure-functions-kafka-extension

@maiqbal11
Copy link
Contributor

@pragnagopa, I'll start the release.

@maiqbal11
Copy link
Contributor

Implemented in Azure/azure-functions-kafka-extension#92

@maiqbal11 maiqbal11 closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants