Accessibility and styling updates for MultiDropDownComponent #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andimarc, |
ammanifold
reviewed
Nov 29, 2017
| } | ||
| // host: { | ||
| // '(document:mousedown)': 'onDocumentMouseDown($event)', | ||
| // } |
ammanifold
reviewed
Nov 30, 2017
| public selectedValues = new ReplaySubject<T[]>(1); | ||
| public hasFocus = false; | ||
|
|
||
| private focusedIndex = -1; |
There was a problem hiding this comment.
private focusedIndex = -1; [](start = 1, length = 27)
needs to be public #Resolved
ammanifold
reviewed
Nov 30, 2017
| <div | ||
| role="combobox" | ||
| [class.focused]="hasFocus && focusedIndex === -1" | ||
| [attr.aria-label]="ariaLabel" |
There was a problem hiding this comment.
"ariaLabel" [](start = 22, length = 11)
variable does not exist #Resolved
ammanifold
reviewed
Nov 30, 2017
| // else if (this.opened) { | ||
| // this._notifyChangeSubscriptions(); | ||
| // } | ||
| // } |
ammanifold
reviewed
Nov 30, 2017
| this.options.forEach(o => o.isSelected = false); | ||
| } | ||
| } | ||
| else { |
There was a problem hiding this comment.
nit: same line #Resolved
andimarc
force-pushed
the
andimarc_multiddfixes
branch
from
6eba3cd
to
7671f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fixes #1738)
I closed the related PR (Accessibility updates for MultiDropDownComponent #1751) because I decided to use aria-activedescendant to handle moving the "focus".
Updates:
Below are the old vs. updated styles (both Light and Dark theme) for the following scenarios: