Set readOnly state for prod dynmic linux. Closes #2565 #2579
Conversation
| @@ -69,14 +70,28 @@ export class MonacoEditorDirective { | |||
|
|
|||
| @Input('disabled') | |||
| set disabled(value: boolean) { | |||
| if (value !== this._disabled) { | |||
| if (typeof value === 'boolean' && value !== this._disabled) { | |||
There was a problem hiding this comment.
why add a check for value's type? also if it is not boolean should we log an error?
There was a problem hiding this comment.
I only added the check because I saw it being null. It's set from the view using readOnlyObservable$ | async I'm guessing that's trying to access readOnlyObeservable before it's set, which the | async pipe converts to null.
We can fix it so that this isn't called until the read only observable not be undefined, or just check that the type is not null here, which typeof value === 'boolean' is indirectly doing. But maybe value !== null will be clearer here. What do you think?
There was a problem hiding this comment.
I would prefer an explicit check for !== null. I also wonder if we should make the signature nullable? (value?: boolean).
There was a problem hiding this comment.
good point. I'll do that. Change sig to nullable and update the check for null
| } | ||
|
|
||
| const setEditorReadOnly = () => { |
There was a problem hiding this comment.
why follow this pattern of creating a setEditorReadOnly function?
There was a problem hiding this comment.
because of the comment above :)
// the editor loads asynchronously outside of our control
// if disabled has been set to true, try to set in a timeout.
// Otherwise we can miss the first "readOnly" set.
// clear the timeout if there was already one.
No description provided.