Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 12263565:[UR2][bugbash]Function monitor page is broken showing l… #2611

Closed
wants to merge 1 commit into from

Conversation

exc3eed
Copy link
Contributor

@exc3eed exc3eed commented Apr 25, 2018

RDBug 12263565:[UR2][bugbash]Function monitor page is broken (showing loading message for ever)

Copy link
Contributor

@nertim nertim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a ScenarioIds.enableAppInsights available. Can you please update the code to use that appropriately? If not, open a bug on me and I can update it. No need to introduce a new scenarioId.

@exc3eed
Copy link
Contributor Author

exc3eed commented Apr 25, 2018

There are difference between ScenarioIds.enableAppInsights and ScenarioIds.appInsightsConfiguration
enableAppInsights can be enabled or disabled based on AppInsights configuration i.e in azure we can enable Appinsights. in this case it will return enabled.
On the other hand ScenarioIds.appInsightsConfiguration tells whether we need to show AppInsight configuration page/componenet/message to user. In some environment like onprem AppInsights is not supported yet that means you cannot configure it and there is no point to show AppInsight configuration page, it should simply default to classic view in this case
So ScenarioIds.enableAppInsights = disabled doesn’t necessarily mean that we have to disable configuration component/message/page. We still need to allow user to configure AppInsights if they want in azure scenario.

@nertim
Copy link
Contributor

nertim commented Apr 25, 2018

I have sent #2615 with the fix we discussed earlier.

@exc3eed exc3eed closed this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants