Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart updates #3135

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Quickstart updates #3135

merged 3 commits into from
Sep 17, 2018

Conversation

ammanifold
Copy link
Contributor

  • Put quickstart files on build server
  • Open deployment center from quickstart

ehamai
ehamai reviewed Sep 14, 2018
View reviewed changes
.../quickstart/step-create-function-instructions/step-create-function-instructions.component.ts Outdated

this._wizardService.instructions.statusChanges.subscribe(() => {
this.instructions = this._wizardService.instructions.value;
});

this._wizardService.deployment.statusChanges.subscribe(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this._wizardService.deployment.statusChanges.subscribe [](start = 8, length = 54)

You need to make sure that you always unsubscribe using takeUntil from long-living observables. Same with the instructions status change above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Elliott, is this what you meant for the unsubscribe? Thanks!

In reply to: 217858161 [](ancestors = 217858161)

@Azure Azure deleted a comment Sep 16, 2018
ehamai
ehamai approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@ehamai ehamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ammanifold ammanifold merged commit 8d20985 into dev Sep 17, 2018
@ammanifold ammanifold deleted the algrunin-quickstart-updates branch September 17, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehamai ehamai ehamai approved these changes

@nertim nertim Awaiting requested review from nertim

@andimarc andimarc Awaiting requested review from andimarc

@hartra344 hartra344 Awaiting requested review from hartra344

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ammanifold @ehamai