Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set attribute target="_blank" on 'Learn More' links for 'Stack' and 'Startup File' in Application Settings blade. #3169

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

andimarc
Copy link
Contributor

(fixes RDBug 13694959)

…Startup File' in Application Settings blade. (fixes RDBug 13694959)
Copy link
Contributor

@nertim nertim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please file an issue to move the link out of the resx file and have it added separately?

@andimarc
Copy link
Contributor Author

@nertim - I pushed another change to move the links out of the resource strings. Can you please take a look?

@@ -1544,13 +1544,13 @@
<value>Stack</value>
</data>
<data name="linuxFxVersionLabelHelp" xml:space="preserve">
<value>Web Apps on Linux provide run-time options through a collection of built in containers. &lt;a href="https://go.microsoft.com/fwlink/?linkid=861969"&gt;Learn more&lt;/a&gt;.</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run-time [](start = 37, length = 8)

check for hyphen?

Copy link
Contributor

@ammanifold ammanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andimarc andimarc merged commit ac3501a into dev Sep 18, 2018
@andimarc andimarc deleted the andimarc_learnmore branch September 18, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants