Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension styling #3222

Merged
merged 3 commits into from
Sep 25, 2018
Merged

Extension styling #3222

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5ba31b
installation styling
Sep 21, 2018
68fe59c
Resource update
Sep 24, 2018
7457885
switch h4s to divs
Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/app/function/extension-checker/extension-checker.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h4>{{ 'extension_template_warning' | translate }}</h4>

<div *ngIf="installing">
<h2>{{ 'extension_install_warning' | translate }}</h2>
<i class="fa fa-refresh fa-spin fa-fw"></i> {{ 'installingExtension' | translate }}
<h4><i class="fa fa-refresh fa-spin fa-fw"></i> {{ 'installingExtension' | translate }}</h4>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this should be a header tag? What is a header for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is the installation text

In reply to: 219922948 [](ancestors = 219922948)

</div>

<div *ngIf="!installing && allInstalled">
Expand Down
2 changes: 1 addition & 1 deletion server/Resources/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2720,7 +2720,7 @@ Set to "External URL" to use an API definition that is hosted elsewhere.</value>
<value>This template requires the following extensions.</value>
</data>
<data name="installingExtension" xml:space="preserve">
<value>Installing template dependencies, you will be able to create a function once this is done. Dependency installation happens in the background and can take up to 2 minutes. You can close this blade and continue to use the portal during this time.</value>
<value>Installing template dependencies. You will be able to create a function once this is done. Dependency installation happens in the background and can take up to 2 minutes. You can close this blade and continue to use the portal during this time.</value>
</data>
<data name="failedToInstallFunctionRuntimeExtensionForId" xml:space="preserve">
<value>We are not able to install runtime extension. Install id {{installationId}}</value>
Expand Down