Accessibility bugs #3272
Merged
Accessibility bugs #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for 'See additinal options/See only recommended options' on pricing tier blade. (https://msazure.visualstudio.com/Antares/_workitems/edit/3118152) [Screen Reader - App Service Plan][MAS 1.3.1]: ARIA attributes must conform to valid values. (https://msazure.visualstudio.com/Antares/_workitems/edit/3118181) [Screen Reader -Isolated -Advanced networking and Scale ] Narrator is not reading the name properly of learn more link correctly under Isolated blade. (https://msazure.visualstudio.com/Antares/_workitems/edit/3118145)
shimedh
requested review from
nertim,
andimarc,
ehamai,
ammanifold and
hartra344
andimarc
reviewed
Oct 8, 2018
client/src/app/site/spec-picker/spec-feature-list/spec-feature-list.component.html
Outdated
Show resolved
Hide resolved
nertim
approved these changes
Oct 9, 2018
hartra344
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Screen Reader - Azure Web - Pricing tier] Incorrect role is defined for 'See additinal options/See only recommended options' on pricing tier blade.
(https://msazure.visualstudio.com/Antares/_workitems/edit/3118152)
[Screen Reader - App Service Plan][MAS 1.3.1]: ARIA attributes must conform to valid values.
(https://msazure.visualstudio.com/Antares/_workitems/edit/3118181)
[Screen Reader -Isolated -Advanced networking and Scale ] Narrator is not reading the name properly of learn more link correctly under Isolated blade.
(https://msazure.visualstudio.com/Antares/_workitems/edit/3118145)
[Note]: using the labelledBy + aria-label combination -> the way the screen reader reads it is the labelledBy id's text then aria-label text and then says link since its a link