Deployment center ga #3284
Merged
Deployment center ga #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartra344
requested review from
nertim,
andimarc,
ehamai,
ammanifold and
shimedh
ammanifold
reviewed
Oct 10, 2018
| @@ -160,8 +159,9 @@ export class KuduDashboardComponent implements OnChanges, OnDestroy { | |||
| return hashNumber; | |||
There was a problem hiding this comment.
nit: should use else if
ammanifold
reviewed
Oct 10, 2018
| @@ -67,12 +66,21 @@ export class VsoDashboardComponent implements OnChanges, OnDestroy { | |||
| deployments: r.deployments, | |||
| VSOData: null, | |||
| }; | |||
| const tableItems = this.deploymentObject.deployments.value.map(element => { | |||
| const tableItems = []; | |||
| this.deploymentObject.deployments.value.forEach(element => { | |||
| const tableItem: ActivityDetailsLog = this._populateActivityDetails(element.properties); | |||
| tableItem.type = 'row'; | |||
There was a problem hiding this comment.
if [](start = 20, length = 2)
same nit
ammanifold
approved these changes
Oct 10, 2018
shimedh
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.