Fix amqp property value that was being release early

[jebrando]

Checklist

• I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
• I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
• If this is a modification that impacts the behavior of a public API
  • I edited the corresponding document in the devdoc folder and added or modified requirements.
• I submitted this PR against the correct branch:
  • This pull-request is submitted against the master branch.
  • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
  • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

[ewertons]

Does not contain unit tests.

[massand]

                else if (type == AMQP_TYPE_STRING)

Please copy the "when this is a string vs int" comment here #Resolved

---

Refers to: provisioning_client/src/prov_transport_amqp_common.c:364 in 06c122a. [](commit_id = 06c122a, deletion_comment = False)

[massand]

                if (desc != NULL && amqpvalue_get_type(desc) == AMQP_TYPE_ULONG)

Questioning why this is a ULONG on error? Please add comment here and clarify with service. #Pending

---

Refers to: provisioning_client/src/prov_transport_amqp_common.c:254 in 06c122a. [](commit_id = 06c122a, deletion_comment = False)

[massand]

                        amqp_info->retry_after_value = (uint32_t)desc_value;

I think its prudent to set this to UINT32_MAX here if there is a value larger here. #Resolved

---

Refers to: provisioning_client/src/prov_transport_amqp_common.c:259 in 06c122a. [](commit_id = 06c122a, deletion_comment = False)