Fix unused variable warning issues #2357
Conversation
JoseSanchez7
requested review from
CIPop,
danewalton,
ericwolz,
ewertons,
jspaith,
preethi826,
RLeclair and
vaavva
as code owners
| @@ -379,7 +379,6 @@ Actions are discarded, since no marshalling will be done for those when sending | |||
| { \ | |||
| AGENT_DATA_TYPES_RESULT result = AGENT_DATA_TYPES_OK; \ | |||
| size_t iMember = 0; \ | |||
| DEFINITION_THAT_CAN_SUSTAIN_A_COMMA_STEAL(phantomName, 1); \ | |||
There was a problem hiding this comment.
what issues were these presenting?
There was a problem hiding this comment.
If I recall correctly, it was that they weren't being used. I checked other files to confirm.
There was a problem hiding this comment.
please have JohnS and Ewerton review these changes in this file
There was a problem hiding this comment.
;tl-dr - this is safe to remove.
From the definition of DEFINITION_THAT_CAN_SUSTAIN_A_COMMA_STEAL (at bottom of this file) is a workaround for a VS2005 preprocessor bug.
We don't support VS2005.
A good thing with this is that if any other preprocessors had this bug that needed this workaround, we'd hit it very early in compilation process. The actual data here is by design meant to be compiled out and have 0 runtime impact.
Co-authored-by: Dane Walton <dane.walton@microsoft.com>
CMakeLists.txt
Outdated
| @@ -131,6 +131,8 @@ if (${warnings_as_errors}) | |||
| # Make warning as error | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror") | |||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-variable -Wmaybe-uninitialized") | |||
There was a problem hiding this comment.
You might need to differentiate between Clang and GCC. Clang looks like it might not have -Wmaybe-uninitialized.
|
Adding suggestion here for putting the compilation in the Linux with Options so that we don't get the bad warnings from all the tests. |
…ure-iot-sdk-c into jose/fix_warning_errors
Co-authored-by: Dane Walton <dane.walton@microsoft.com>
Co-authored-by: Dane Walton <dane.walton@microsoft.com>
Description of the problem:
Warnings of unused variables were being produced upon compilation. See link to issue below:
Link: Azure/azure-c-shared-utility#599
Description of the solution:
Replaced instances of "static char *" with "#define" for certain string constants in include files. Also, deleted variables that weren't used elsewhere in the code.