Continue consolidating the auth methods for the hub device (#2854)

SDK v2 migration guide.md

@@ -109,6 +109,7 @@ but users are still encouraged to migrate to version 2 when they have the chance
 - The exponential back-off retry policy has updated parameters and logic.
 - Remote certificate validation is no natively longer supported for AMQP web socket connections.
   - The supported workaround is to provide a client web socket instance in the client options.
+- The authentication classes for devices and modules have been consolidated.
 
 #### Notable additions
 

e2e/test/iothub/DeviceClientX509AuthenticationE2ETests.cs

@@ -111,8 +111,8 @@ public async Task X509_Cert_Chain_Install_Test_MqttTcp()
             };
             var auth = new ClientAuthenticationWithX509Certificate(
                 s_chainCertificateWithPrivateKey,
-                TestConfiguration.IotHub.X509ChainDeviceName,
-                chainCertificates: chainCerts);
+                chainCerts,
+                TestConfiguration.IotHub.X509ChainDeviceName);
             using var deviceClient = new IotHubDeviceClient(
                 _hostName,
                 auth,
@@ -139,8 +139,8 @@ public async Task X509_Cert_Chain_Install_Test_AmqpTcp()
             };
             var auth = new ClientAuthenticationWithX509Certificate(
                 s_chainCertificateWithPrivateKey,
-                TestConfiguration.IotHub.X509ChainDeviceName,
-                chainCertificates: chainCerts);
+                chainCerts,
+                TestConfiguration.IotHub.X509ChainDeviceName);
             using var deviceClient = new IotHubDeviceClient(
                 _hostName,
                 auth,

e2e/test/iothub/DeviceTokenRefreshE2ETests.cs

@@ -112,7 +112,7 @@ public async Task IotHubDeviceClient_TokenConnectionDoubleRelease_Ok()
                 Target = $"{iotHub}/devices/{WebUtility.UrlEncode(deviceId)}",
             };
 
-            var auth = new ClientAuthenticationWithToken(builder.ToSignature(), deviceId);
+            var auth = new ClientAuthenticationWithSharedAccessSignature(builder.ToSignature(), deviceId);
 
             using var deviceClient = new IotHubDeviceClient(iotHub, auth, new IotHubClientOptions(new IotHubClientAmqpSettings()));
             VerboseTestLogger.WriteLine($"{deviceId}: Created {nameof(IotHubDeviceClient)}");
@@ -140,7 +140,7 @@ public async Task IotHubDeviceClient_CreateFromConnectionString_TokenIsRefreshed
             using var deviceDisconnected = new SemaphoreSlim(0);
 
             TestDevice testDevice = await TestDevice.GetTestDeviceAsync(DevicePrefix).ConfigureAwait(false);
-            var auth = new ClientAuthenticationWithConnectionString(testDevice.ConnectionString, sasTokenTimeToLive, sasTokenRenewalBuffer);
+            var auth = new ClientAuthenticationWithSharedAccessKeyRefresh(testDevice.ConnectionString, sasTokenTimeToLive, sasTokenRenewalBuffer);
 
             var options = new IotHubClientOptions(new IotHubClientMqttSettings());
 

e2e/test/provisioning/ProvisioningE2ETests.cs

@@ -1065,7 +1065,7 @@ public static ProvisioningClientOptions CreateProvisioningClientOptionsFromName(
             }
             else if (provisioningAuth is AuthenticationProviderSymmetricKey symmetricKeyAuth)
             {
-                auth = new ClientAuthenticationWithRegistrySymmetricKey(symmetricKeyAuth.GetPrimaryKey(), deviceId);
+                auth = new ClientAuthenticationWithSharedAccessKeyRefresh(symmetricKeyAuth.GetPrimaryKey(), deviceId);
             }
             else
             {

iothub/device/samples/how to guides/X509DeviceCertWithChainSample/Program.cs

@@ -40,7 +40,7 @@ public static async Task<int> Main(string[] args)
                 new X509Certificate2(parameters.Intermediate2CertPath)
             };
             using var deviceCert = new X509Certificate2(parameters.DevicePfxPath, parameters.DevicePfxPassword);
-            var auth = new ClientAuthenticationWithX509Certificate(deviceCert, parameters.DeviceName, chainCertificates: chainCerts);
+            var auth = new ClientAuthenticationWithX509Certificate(deviceCert, chainCerts, parameters.DeviceName);
 
             var options = new IotHubClientOptions(parameters.GetHubTransportSettings());
             using var deviceClient = new IotHubDeviceClient(

iothub/device/samples/solutions/PnpDeviceSamples/TemperatureController/Program.cs

@@ -108,7 +108,7 @@ private static async Task<IotHubDeviceClient> SetupDeviceClientAsync(Parameters
                 case "dps":
                     logger.LogDebug($"Initializing via DPS");
                     DeviceRegistrationResult dpsRegistrationResult = await ProvisionDeviceAsync(parameters, cancellationToken);
-                    var authMethod = new ClientAuthenticationWithRegistrySymmetricKey(parameters.DeviceSymmetricKey, dpsRegistrationResult.DeviceId);
+                    var authMethod = new ClientAuthenticationWithSharedAccessKeyRefresh(parameters.DeviceSymmetricKey, dpsRegistrationResult.DeviceId);
                     deviceClient = InitializeDeviceClient(dpsRegistrationResult.AssignedHub, authMethod);
                     break;
 

iothub/device/samples/solutions/PnpDeviceSamples/Thermostat/Program.cs

@@ -101,7 +101,7 @@ private static async Task<IotHubDeviceClient> SetupDeviceClientAsync(Parameters
                 case "dps":
                     logger.LogDebug($"Initializing via DPS");
                     DeviceRegistrationResult dpsRegistrationResult = await ProvisionDeviceAsync(parameters, cancellationToken);
-                    var authMethod = new ClientAuthenticationWithRegistrySymmetricKey(parameters.DeviceSymmetricKey, dpsRegistrationResult.DeviceId);
+                    var authMethod = new ClientAuthenticationWithSharedAccessKeyRefresh(parameters.DeviceSymmetricKey, dpsRegistrationResult.DeviceId);
                     deviceClient = InitializeDeviceClient(dpsRegistrationResult.AssignedHub, authMethod);
                     break;