Continue consolidating the auth methods for the hub device #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okenRefresh, rename ClientAuthenticationWithToken to ClientAuthenticationWithSharedAccessSignature
brycewang-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
reviewed
Oct 12, 2022
iothub/device/src/Authentication/AuthenticationWithTokenRefresh.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
Oct 12, 2022
|
I'd like to hold this for now until we have the v2 sync meeting to decide if anything else we want to consolidate further for the auth methods in the hub device. |
iothub/device/src/Authentication/Security/SharedAccessSignatureBuilder.cs
Outdated
Show resolved
Hide resolved
iothub/device/src/Authentication/AuthenticationWithTokenRefresh.cs
Outdated
Show resolved
Hide resolved
…nRefresh, and update unit tests
…cationWithRegistrySymmetricKey and ClientAuthenticationWithSharedAccessPolicy
…ogging for large value of TTL and renewal buffer
iothub/device/src/Authentication/ClientAuthenticationWithSakRefresh.cs
Outdated
Show resolved
Hide resolved
iothub/device/src/Authentication/IotHubConnectionCredentials.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Oct 19, 2022
iothub/device/src/Authentication/ClientAuthenticationWithSakRefresh.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Oct 19, 2022
iothub/device/src/Authentication/ClientAuthenticationWithSakRefresh.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
Oct 19, 2022
iothub/device/src/Authentication/ClientAuthenticationWithSakRefresh.cs
Outdated
Show resolved
Hide resolved
…SharedAccessKeyRefresh
drwill-ms
reviewed
Oct 19, 2022
iothub/device/src/Authentication/ClientAuthenticationWithSharedAccessKeyRefresh.cs
Show resolved
Hide resolved
iothub/device/src/Authentication/ClientAuthenticationWithTokenRefresh.cs
Outdated
Show resolved
Hide resolved
abhipsaMisra
approved these changes
Oct 19, 2022
…sh and fix ordering of param
…fix ordering of param
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's addressed in this PR:
ClientAuthenticationWithConnectionString.cs,ClientAuthenticationWithRegistrySymmetricKey.csandClientAuthenticationWithSharedAccessPolicy.csintoClientAuthenticationWithSakRefresh.csAfter these changes, the auth methods on the hub device side will be like this.