small bug with the Device Explorer tool UpdateTwinAsync is not awaited #64
Assignees
Labels
Comments
|
@ukluk - Please submit a PR and we'll review it. Thanks. |
|
@tameraw I am not authorized: Request failed with status code: 403.
Let me know how to contribute 😊
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: tameraw<mailto:notifications@github.com>
Sent: Friday, March 3, 2017 1:07 PM
To: Azure/azure-iot-sdk-csharp<mailto:azure-iot-sdk-csharp@noreply.github.com>
Cc: ukluk<mailto:uriel_kluk@hotmail.com>; Mention<mailto:mention@noreply.github.com>
Subject: Re: [Azure/azure-iot-sdk-csharp] small bug with the Device Explorer tool UpdateTwinAsync is not awaited (#64)
@ukluk<https://github.com/ukluk> - Please submit a PR and we'll review it. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#64 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADEEDOFlMuDTk7vivBeHRWQnGShnOMOGks5riGT-gaJpZM4MSTOs>.
|
|
Hello @ukluk , I see that you managed to do the change :). All Best |
anushprabhu
pushed a commit
to anushprabhu/azure-iot-sdk-csharp
that referenced
this issue
Sep 13, 2018
AMQP - handle sync completion
CIPop
pushed a commit
to CIPop/azure-iot-sdk-csharp
that referenced
this issue
Oct 5, 2018
AMQP - handle sync completion
CIPop
pushed a commit
to CIPop/azure-iot-sdk-csharp
that referenced
this issue
Oct 8, 2018
AMQP - handle sync completion
CIPop
pushed a commit
to CIPop/azure-iot-sdk-csharp
that referenced
this issue
Oct 9, 2018
AMQP - handle sync completion
CIPop
pushed a commit
to CIPop/azure-iot-sdk-csharp
that referenced
this issue
Oct 9, 2018
AMQP - handle sync completion
CIPop
added a commit
that referenced
this issue
Oct 9, 2018
* Merge pull request #66 from Azure/alextolp/setcompletedsync Setting CompletedSynchronously everywhere * Provisioning MQTT transport using the ExecutorTaskScheduler. * Device MQTT transport using the ExecutorTaskScheduler. * Removing ConcurrentObjectPool. * Merge pull request #63 from Azure/ravokkar/tpmamqpws-tracing Add client side tracing to the TPM over AMQP/WS scenario * Merge pull request #64 from Azure/alextolp/amqpsyncfix AMQP - handle sync completion * Merge pull request #65 from Azure/alextolp/amqpwsaddlogs Add logs for amqp ws tpm * Fixing synchronous completions for AMQP. * Adding test execution note. * Changing build order of netfx.
brycewang-microsoft
pushed a commit
that referenced
this issue
Jul 14, 2022
update code (1 place) and comments to reference service shared access…
brycewang-microsoft
pushed a commit
that referenced
this issue
Jul 15, 2022
update code (1 place) and comments to reference service shared access…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On class DeviceTwinAndMethod
Line 82:
registryManager.UpdateTwinAsync(dp.DeviceId, dp, dp.ETag);
UpdateTwinAsync not awaited. There is a delay for one second, but if there is a problem it will not be catched.
change to:
await registryManager.UpdateTwinAsync(dp.DeviceId, dp, dp.ETag);
The text was updated successfully, but these errors were encountered: