Mqtt changes #660
Merged
Mqtt changes #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIPop
requested review from
alextolp,
prmathur-microsoft,
abhipsaMisra and
nayato
CIPop
force-pushed
the
mqttChanges
branch
2 times, most recently
from
d207270
to
24d2c19
Compare
Setting CompletedSynchronously everywhere
Add logs for amqp ws tpm
AMQP - handle sync completion
Add client side tracing to the TPM over AMQP/WS scenario
nayato
reviewed
Oct 9, 2018
| @@ -21,6 +21,11 @@ namespace Microsoft.Azure.Devices.Client.Transport.Mqtt | |||
| using Microsoft.Azure.Devices.Client.Extensions; | |||
| using System.Diagnostics; | |||
|
|
|||
| // | |||
| // Note on ConfigureAwait: dotNetty is using a custom TaskScheduler that binds Tasks to the corresponding | |||
| // EventLoopGroup. To limit I/O to the EventLoopGroup and keep Netty semantics, we are going to ensure that the | |||
There was a problem hiding this comment.
replace EventLoopGroup with EventLoop
There was a problem hiding this comment.
Addressed in a personal branch that will be pushed soon for both DeviceClient and ProvisioningClient comments.
| () => new MultithreadEventLoopGroup(eg => new SingleThreadEventLoop(eg, "MQTTExecutionThread", TimeSpan.FromSeconds(1)), 1), | ||
| TimeSpan.FromSeconds(5), | ||
| elg => elg.ShutdownGracefullyAsync()); | ||
| private static MultithreadEventLoopGroup s_eventLoopGroup = new MultithreadEventLoopGroup(); |
There was a problem hiding this comment.
Be aware that this will start Environment.ProcessorCount * 2 number of threads immediately. Not sure if there is a concern with this on smaller devices.
There was a problem hiding this comment.
I'll leave it as-is for now: In a future SDK version we should expose the handler and the detailed configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Description of the changes
Reference/Link to the issue solved with this PR (if any)
Fixes #552