feat(registry-manager): Add support to use user defined msi for import export jobs. #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinagesh
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
jamdavi and
timtay-microsoft
as code owners
vinagesh
changed the title
vinagesh
commented
Apr 26, 2021
| @@ -118,6 +118,13 @@ public JobProperties() | |||
| [JsonProperty(PropertyName = "storageAuthenticationType", NullValueHandling = NullValueHandling.Ignore)] | |||
| public StorageAuthenticationType? StorageAuthenticationType { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// The managed identity used to access the storage account for import and export jobs. | |||
There was a problem hiding this comment.
@nimengan - Here is the description I added. We should keep this consistent across SDKs and in the swagger. At the moment we don't have any description for this in the swagger.
vinagesh
commented
Apr 26, 2021
barustum
reviewed
Apr 27, 2021
barustum
reviewed
Apr 27, 2021
barustum
reviewed
Apr 27, 2021
barustum
approved these changes
Apr 27, 2021
vinagesh
added a commit
that referenced
this pull request
May 10, 2021
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
…re#1948) * feat(registry-manager): Add support to use user defined msi for import export jobs. (Azure#1915) * feat(e2e): Adding e2e test for msi support on import jobs. (Azure#1925) * Updating yaml files to run new tests (Azure#1946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Description of the changes
This contains the implementation to support using configured user defined managed identity to perform import and export jobs. What this means is the hub itself will use the passed in managed identity (in JobProperties) to perform operations on the storage account used during import and export.
This feature is still under a ff and only works on a specific subscription. I've tested these changes against that and pushing the code to a feature branch. I have not turned on any gates for this branch as the feature is not yet available in canary. Once it is available, I will create the required assets and add the gating.
Details about where the feature is enabled and how to use it:
https://review.docs.microsoft.com/en-us/azure/iot-hub/iot-hub-managed-identity?branch=pr-en-us-154985
Use following subscriptions for creating the hub.
1. DEVICEHUB_DEV1 [91d12660-3dec-467a-be2a-213b5544ddc0]
2. IOT_PLATFORM_UPX_TEST --> portal team test sub
Use this link for your portal access https://ms.portal.azure.com/?feature.canmodifystamps=true&Microsoft_Azure_Iothub=tip1