feat(e2e): Adding e2e test for msi support on import jobs. #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinagesh
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
jamdavi and
timtay-microsoft
as code owners
barustum
reviewed
Apr 29, 2021
| @@ -84,6 +85,16 @@ public async Task RegistryManager_ImportDevices(StorageAuthenticationType storag | |||
| { | |||
| try | |||
| { | |||
| ManagedIdentity identity = null; | |||
There was a problem hiding this comment.
What do we do with identity in this test? I only see it being assigned on line 92.
There was a problem hiding this comment.
We just pass it in and the test should succeed. The lines 43-45 dictate if the test should run this job with the identity or key.
barustum
approved these changes
Apr 30, 2021
vinagesh
added a commit
that referenced
this pull request
May 10, 2021
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
…re#1948) * feat(registry-manager): Add support to use user defined msi for import export jobs. (Azure#1915) * feat(e2e): Adding e2e test for msi support on import jobs. (Azure#1925) * Updating yaml files to run new tests (Azure#1946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Description of the changes
Reference/Link to the issue solved with this PR (if any)