Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the reconnection sample to use the retry policy fully, rather than wrap another retry policy around method calls #2827

Merged
merged 2 commits into from Oct 6, 2022
Merged

Update the reconnection sample to use the retry policy fully, rather than wrap another retry policy around method calls #2827

merged 2 commits into from Oct 6, 2022

Conversation

drwill-ms
Copy link
Contributor

The additional retry policy on top of the SDK calls always bugged me. While investigating how retry policy works, I realized we can simply override it and then the SDK does what we want.

Other code cleanup. Comments inline.

@drwill-ms
Update the reconnection sample to use the retry policy fully, rather …
3940fa8 
…than wrap another retry policy around method calls
@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms drwill-ms merged commit ce53238 into main Oct 6, 2022
@drwill-ms drwill-ms deleted the drwill/reconnection-sample branch October 6, 2022 01:24
@brycewang-microsoft brycewang-microsoft mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@timtay-microsoft timtay-microsoft timtay-microsoft approved these changes

@patilsnr patilsnr patilsnr approved these changes

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@brycewang-microsoft brycewang-microsoft Awaiting requested review from brycewang-microsoft brycewang-microsoft is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

@ngastelum-ms ngastelum-ms Awaiting requested review from ngastelum-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drwill-ms @abhipsaMisra @timtay-microsoft @brycewang-microsoft @patilsnr