Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch TLS exceptions during connect #2928

Merged
merged 3 commits into from Nov 2, 2022
Merged

Catch TLS exceptions during connect #2928

merged 3 commits into from Nov 2, 2022

Conversation

brycewang-microsoft
Copy link
Contributor

@brycewang-microsoft brycewang-microsoft commented Oct 31, 2022 •
edited

Addressing this

abhipsaMisra
abhipsaMisra approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the linked sample changes are going to come in another PR?

@brycewang-microsoft
Copy link
Contributor Author

I'm assuming the linked sample changes are going to come in another PR?

That linked sample is actually on main, and the reconnection sample on previews/v2 here can leverage the changes in this PR.

brycewang-microsoft
brycewang-microsoft commented Nov 1, 2022
View reviewed changes
iothub/device/tests/Pipeline/ErrorDelegatingHandlerTests.cs
Comment on lines -144 to -149
private static async Task OperationAsync_ExceptionThrownAndThenSucceed_OperationSuccessfullyCompleted(
Func<IDelegatingHandler, Task<Message>> mockSetup,
Func<IDelegatingHandler, Task<Message>> act,
Func<IDelegatingHandler, Task<Message>> assert,
Type thrownExceptionType,
Type expectedExceptionType)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused private method

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft brycewang-microsoft merged commit d21b8b7 into previews/v2 Nov 2, 2022
@brycewang-microsoft brycewang-microsoft deleted the brycewang/tls-exception branch November 2, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtay-microsoft timtay-microsoft timtay-microsoft left review comments

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@drwill-ms drwill-ms Awaiting requested review from drwill-ms

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

@ngastelum-ms ngastelum-ms Awaiting requested review from ngastelum-ms

@patilsnr patilsnr Awaiting requested review from patilsnr patilsnr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brycewang-microsoft @abhipsaMisra @timtay-microsoft