fix the authentcationType enums values #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilmaznaslan
requested review from
timtay-microsoft,
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
reviewed
Sep 21, 2022
...ervice-client/src/main/java/com/microsoft/azure/sdk/iot/service/auth/AuthenticationType.java
Outdated
Show resolved
Hide resolved
|
/azp run |
drwill-ms
approved these changes
Sep 21, 2022
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
The same error message was also occurring for the |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
...ervice-client/src/main/java/com/microsoft/azure/sdk/iot/service/auth/AuthenticationType.java
Show resolved
Hide resolved
…dk/iot/service/auth/AuthenticationType.java add serializer for AuthenticationType.SAS Co-authored-by: timtay-microsoft <timtay@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Thanks for the fix, @yilmaznaslan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch.Reference/Link to the issue solved with this PR (if any)
Importing devices from blob to iothub fails if the Authentication.Type is SELF_SIGNED
Description of the problem
AuthenticationType enum values doesn't match the IoTHub Authentication type values. See the issue for more detial
Description of the solution
I changed the enum values to correct ones that match to
Microsoft.Azure.Devices.Cloud.AuthenticationType