Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up function signatures to fix compile errors #120

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

nebrius
Copy link
Contributor

@nebrius nebrius commented Oct 25, 2017

This PR changes the function signatures in the derived AMQP class to more accurately match the signatures of the methods that it overrides.

Note: this is a type signature change only, this does not change the compiled output AFAICT.

Checklist

Reference/Link to the issue solved with this PR (if any)

#119

Description of the problem

There are some inconsistencies in one of the derived classes in this module that causes it to not compile in some apps using this module. For more details, please see #119

Description of the solution

This approach fixes the problem by updating the signatures of the overridden methods in the Amqp class to match those in the Client.Transport class.

This PR changes the function signatures in the derived AMQP class to more accurately match the signatures of the methods that it overrides.

Note: this is a type signature change only, this does not change the compiled output AFAICT.
@pierreca pierreca self-requested a review October 25, 2017 22:03
@pierreca pierreca self-assigned this Oct 25, 2017
@pierreca pierreca added the bug label Oct 25, 2017
@az-iot-builder-01 az-iot-builder-01 merged commit 03b4517 into Azure:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants